search

flathub / org.darktable.Darktable

https://flathub.org/apps/details/org.darktable.Darktable
5 stars 14 forks source link

Update to 3.0 #48

Closed matze closed 4 years ago

matze commented 4 years ago

Also integrates the changes from #46.

flathubbot commented 4 years ago

Started test build 12983

flathubbot commented 4 years ago

Build 12983 failed

flathubbot commented 4 years ago

Started test build 12987

flathubbot commented 4 years ago

Started test build 12988

flathubbot commented 4 years ago

Build 12987 was cancelled

flathubbot commented 4 years ago

Build 12988 failed

hfiguiere commented 4 years ago

It fail to build. This is because of darktable-org/darktable#3688

When I asked the other day about "a compiler with graphite support enabled" there was no answer.

hfiguiere commented 4 years ago

And pr #46 fails on aarch64 (to update 2.6.3 to the latest SDK)

matze commented 4 years ago

And pr #46 fails on aarch64 (to update 2.6.3 to the latest SDK)

I was thinking of just disabling ARM builds. About the Graphite optimization … I am still googling.

flathubbot commented 4 years ago

Started test build 12989

flathubbot commented 4 years ago

Build 12989 failed

hfiguiere commented 4 years ago

FWIW it builds on F31 with gcc. (but not inside the flatpak SDK)

matze commented 4 years ago

So what options do we have? Patching those optimizations out?

hfiguiere commented 4 years ago

I asked back when I was trying to flatpak the rc on the freedesktop-sdk channel and heard nothing.

Upstream seems to have no concerns about the issue, so much that they won't even try to detect it. (issue was closed without action)

I think the proper solution is to get the toolchain fixed in freedesktop-sdk since things work out of the box on, say, Fedora.

hfiguiere commented 4 years ago

Filed a freedesktop-sdk issue;

https://gitlab.com/freedesktop-sdk/freedesktop-sdk/issues/943

barthalion commented 4 years ago

I replied there. I can imagine FDO SDK team may be unwilling to fix it for existing releases as it would require major rebuild, but let's wait for their answer.

In the worst case we can revive GCC SDK extension or create DarkTable baseapp achieving the same (to make it clear we don't want it used for other apps).

Erick555 commented 4 years ago

@hfiguiere freedesktop-sdk runtime on flathub should be fixed now (19.08.07).

flathubbot commented 4 years ago

Started test build 14775

flathubbot commented 4 years ago

Build 14775 failed

hfiguiere commented 4 years ago

it's not. I commented on the upstream SDK bug.

flathubbot commented 4 years ago

Started test build 14776

flathubbot commented 4 years ago

Build 14776 failed

Erick555 commented 4 years ago

@hfiguiere it's fixed only in freedesktop-sdk, you have to wait til gnome releases new 3.34.

hfiguiere commented 4 years ago

OK.

For reference https://gitlab.gnome.org/GNOME/gnome-build-meta/merge_requests/501

hfiguiere commented 4 years ago

bot, build org.darktable.Darktable

flathubbot commented 4 years ago

Queued test build for org.darktable.Darktable.

flathubbot commented 4 years ago

Started test build 14933

hfiguiere commented 4 years ago

It's likely gonna fail. It needs a different version of lensfun.

flathubbot commented 4 years ago

Build 14933 failed

hfiguiere commented 4 years ago

You need this change for lensfun modules

-                    "commit": "3724bdbbfc00e171d5cea2c66fb3668d0f3acebb"
+                    "commit": "b7c7e49a3601690f3225b99a0acbe7272fe68bfa",
+                    "tag": "v0.3.95"
flathubbot commented 4 years ago

Started test build 14934

flathubbot commented 4 years ago

Build 14934 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/14260/org.darktable.Darktable.flatpakref
matze commented 4 years ago

Let's merge it?

hfiguiere commented 4 years ago

merged