search

flathub / org.darktable.Darktable

https://flathub.org/apps/details/org.darktable.Darktable
5 stars 14 forks source link

Support colord #49

Closed Hofer-Julian closed 4 years ago

Hofer-Julian commented 4 years ago

Fixes #44

flathubbot commented 4 years ago

Started test build 14751

flathubbot commented 4 years ago

Build 14751 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/14083/org.darktable.Darktable.flatpakref
paperdigits commented 4 years ago

@Hofer-Julian if I run darktable-cmtest inside the flatpak sandbox, will it report back the monitor profile set by the system's colord?

flathubbot commented 4 years ago

Started test build 14769

Hofer-Julian commented 4 years ago

@Hofer-Julian if I run darktable-cmtest inside the flatpak sandbox, will it report back the monitor profile set by the system's colord?

Yes, you can try

 flatpak install --user https://dl.flathub.org/build-repo/14083/org.darktable.Darktable.flatpakref

to check if it also works on your system.

flathubbot commented 4 years ago

Build 14769 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/14099/org.darktable.Darktable.flatpakref
flathubbot commented 4 years ago

Started test build 14955

Hofer-Julian commented 4 years ago

I removed the dconf permissions again, as you use 3.34 now

flathubbot commented 4 years ago

Build 14955 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/14282/org.darktable.Darktable.flatpakref
hfiguiere commented 4 years ago

Yes we do use 3.34 runtime, but it is also Darktable 3.0 now. You actually need to rebase the pull request on the current master.

hfiguiere commented 4 years ago

For the record the current darktable package show this:

flatpak run --command=darktable-cmstest org.darktable.Darktable
darktable-cmstest version 3.0.0
this executable was built with colord support enabled
darktable itself was built with colord support enabled

couldn't locate primary CRTC!
error connecting to colord

XWAYLAND0   the X atom and colord returned the same profile
    X atom: _ICC_PROFILE (0 bytes)
        description: (none)
    colord: "(none)"
        description: (file not found)

Better check your system setup
 - some monitors lacked a profile
You may experience inconsistent color rendition between color managed applications

(I don't have a profile set on this machine, but it show the colord error)

flathubbot commented 4 years ago

Started test build 14980

Hofer-Julian commented 4 years ago

Yes we do use 3.34 runtime, but it is also Darktable 3.0 now. You actually need to rebase the pull request on the current master.

@hfiguiere Done.

flathubbot commented 4 years ago

Build 14980 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/14307/org.darktable.Darktable.flatpakref
Hofer-Julian commented 4 years ago

My output:

flatpak run --command=sh org.darktable.Darktable 
[📦 org.darktable.Darktable ~]$ darktable-cmstest 
darktable-cmstest version 3.0.0
this executable was built with colord support enabled
darktable itself was built with colord support enabled

primary CRTC is at CRTC 0
CRTC for screen 0 CRTC 1 has no mode or no output, skipping
CRTC for screen 0 CRTC 2 has no mode or no output, skipping

HDMI-1  the X atom and colord returned the same profile
    X atom: _ICC_PROFILE (1460 bytes)
        description: 23MB35
    colord: "/home/julian/.local/share/icc/edid-0a7fad8ba3e1ea6263c93e2a07623246.icc"
        description: 23MB35

Your system seems to be correctly configured
flathubbot commented 4 years ago

Started test build 15034

flathubbot commented 4 years ago

Build 15034 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/14361/org.darktable.Darktable.flatpakref
hfiguiere commented 4 years ago

Thank you so much.