flathub / org.darktable.Darktable

https://flathub.org/apps/details/org.darktable.Darktable
5 stars 14 forks source link

Update the lensfun database when building the flatpak. #58

Closed paperdigits closed 4 years ago

paperdigits commented 4 years ago

Grab the latest lens definitions at build time, remove the lens definitions from the lensfun git repo, then replace them with the new definitions. Fixes #56.

flathubbot commented 4 years ago

Started test build 19625

flathubbot commented 4 years ago

Build 19625 failed

flathubbot commented 4 years ago

Started test build 19626

paperdigits commented 4 years ago

bot, build

flathubbot commented 4 years ago

Queued test build for org.darktable.Darktable.

flathubbot commented 4 years ago

Started test build 19627

flathubbot commented 4 years ago

Build 19626 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/18830/org.darktable.Darktable.flatpakref
hfiguiere commented 4 years ago

With that the build is no longer reproducible. But whatever.

flathubbot commented 4 years ago

Build 19627 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/18831/org.darktable.Darktable.flatpakref
paperdigits commented 4 years ago

@hfiguiere is the attitude really necessary? If you don't like this way, then lets continue to work towards a solution.

hfiguiere commented 4 years ago

@hfiguiere is the attitude really necessary? If you don't like this way, then lets continue to work towards a solution

I had a solution that was addressing what I'm saying is no longer happening, no one seem to like it. But no one seem to have something "better". A tarball whose shasum change over time is NOT a good idea.

And as someone who actually do the maintenance it just mean more work for me. Or maybe not. I can just stop.

paperdigits commented 4 years ago

I understand that your feelings are hurt because people seemed to not like your solution, but do you need to take it out on me? Are we not working towards the same goal?

You don't have to be the only maintainer here, either.

flathubbot commented 4 years ago

Started test build 19678

paperdigits commented 4 years ago

I've updated the manifest to pull git master from lensfun, then copy over the database files. I still don't understand how to tell the difference between the two sources if they're in the same module. Pulling git master results in a reproducible build, and we probably only need to periodically update the master commit hash.

flathubbot commented 4 years ago

Build 19678 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/18882/org.darktable.Darktable.flatpakref
hfiguiere commented 4 years ago

Obsoleted by #59