Add exiftool to the sandbox in support of certain Lua scripts

[rrenomeron]

Some Lua scripts supporting automatic styling of photos on import run exiftool in order to take action based on the imported photo's EXIF. This adds exiftool and its perl dependency to the sandbox so that it can run. A more secure approach than #97.

Inspired by https://github.com/flathub/io.github.hvdwofl.jExifToolGUI.

[flathubbot]

Started test build 6542

[flathubbot]

Build 6542 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/118998/org.darktable.Darktable.flatpakref

[paperdigits]

Which lua scripts are these?

On November 13, 2022 10:58:29 AM PST, Rich Renomeron @.***> wrote:

Some Lua scripts supporting automatic styling of photos on import run exiftool in order to take action based on the imported photo's EXIF. This adds exiftool and its perl dependency to the sandbox so that it can run. A more secure approach than #97.

Inspired by https://github.com/flathub/io.github.hvdwofl.jExifToolGUI.

You can view, comment on, or merge this pull request online at:

https://github.com/flathub/org.darktable.Darktable/pull/98

-- Commit Summary --

• Add exiftool (and perl) to manifest

-- File Changes --

M org.darktable.Darktable.json (75)

-- Patch Links --

https://github.com/flathub/org.darktable.Darktable/pull/98.patch https://github.com/flathub/org.darktable.Darktable/pull/98.diff

-- Reply to this email directly or view it on GitHub: https://github.com/flathub/org.darktable.Darktable/pull/98 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

[rrenomeron]

This one: https://bastibe.de/2022-05-04-customizing-darktable-for-fujifilm-cameras.html and these from the darktable.org repo:

• fujifilm_dynamic_range.lua
• fujifilm_ratings.lua
• enfusedAdvanced.lua

[hfiguiere]

bot, build

[flathubbot]

Queued test build for org.darktable.Darktable.

[flathubbot]

Started test build 10815

[flathubbot]

Build 10815 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/123269/org.darktable.Darktable.flatpakref

[hfiguiere]

The package goes from 91.2MB to 149.1MB

[rrenomeron]

That would be the perl runtime needed by Exiftool adding on all those megabytes.

[paperdigits]

It'd be much nicer if the lua was modified to use exiv2, which does much the same thing but is already in the sandbox.

Since lua can call anything.... Are we going to support everything?

On December 10, 2022 8:06:51 AM PST, Rich Renomeron @.***> wrote:

That would be the perl runtime needed by Exiftool adding on all those megabytes.

-- Reply to this email directly or view it on GitHub: https://github.com/flathub/org.darktable.Darktable/pull/98#issuecomment-1345295875 You are receiving this because you commented.

Message ID: @.***>

[rrenomeron]

Unfortunately, exiv2 can't display the "Auto Dynamic Range" tag for Fujifilm cameras.

[nalsai]

Couldn't exiftool be made into an extension? People who need exiftool could install the extension and the package can be kept small for people who don't need it.

[flathubbot]

Started test build 13781

[rrenomeron]

Something like this looks promising: https://blog.tingping.se/2018/03/18/flatpaking-plugins.html. I'm happy to give it a try. @Nalsai, if you know of a better reference for this, please chime in.

[flathubbot]

Build 13781 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/126209/org.darktable.Darktable.flatpakref

[paperdigits]

@rrenomeron that seems like the right approach

[flathubbot]

Started test build 28511

[flathubbot]

Build 28511 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/11180/org.darktable.Darktable.flatpakref

[flathubbot]

Started test build 28513

[flathubbot]

Build 28513 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/11182/org.darktable.Darktable.flatpakref

[hfiguiere]

Couldn't exiftool be made into an extension? People who need exiftool could install the extension and the package can be kept small for people who don't need it.

Given the dependency on Perl, no.

[hfiguiere]

Unfortunately, exiv2 can't display the "Auto Dynamic Range" tag for Fujifilm cameras.

Maybe submitting a patch to Exiv2? That seems to be a better long term solution.