search

flathub / org.electronjs.Electron2.BaseApp

7 stars 16 forks source link

Remove unused NSS patch #22

Closed vially closed 1 year ago

vially commented 3 years ago

It looks like this patch was initially added in 84f1d85372cc541420f979ba5b668e935a8f4659 when there was still a NSS module but it wasn't cleaned up when the NSS dependency got removed in 99f70d16e906c751a61b3c4813a82415315f8b6b.

So it looks like it's currently unused so it should be safe to remove.

flathubbot commented 3 years ago

Started test build 42364

flathubbot commented 3 years ago

Build 42364 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/40756/org.electronjs.Electron2.BaseApp.flatpakref
bbhtt commented 1 year ago

This patch no longer exists on the currently supported branches branch/23.08 and branch/22.08

Looks like it was removed when branch/21.08 was created https://github.com/flathub/org.electronjs.Electron2.BaseApp/commit/8198c31097ff39a3ed6e8b9b7f8687b4a1a4207c

So I'm closing this. Thanks for the PR!