search

flathub / org.electronjs.Electron2.BaseApp

7 stars 16 forks source link

Provide libsecret from shared modules for os_crypt #53

Closed ZVNexus closed 9 months ago

flathubbot commented 9 months ago

Started test build 95809

ZVNexus commented 9 months ago

@bbhtt @TingPing Can you take a look at this? Also worth noting the Chromium base app already includes this: https://github.com/flathub/org.chromium.Chromium.BaseApp/blob/branch/23.08/org.chromium.Chromium.BaseApp.yaml#L8

flathubbot commented 9 months ago

Build 95809 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/78559/org.electronjs.Electron2.BaseApp.flatpakref
bbhtt commented 9 months ago

Seems fine to me. There are quite a few applications adding it from the shared modules, they should be notified of the change

https://github.com/search?q=org%3Aflathub+org.electronjs.Electron2.BaseApp+libsecret.json&type=code&p=1

ZVNexus commented 9 months ago

Seems fine to me. There are quite a few applications adding it from the shared modules, they should be notified of the change

What's the best way of going about that, pinging them here or creating issues in each repo?

bbhtt commented 9 months ago

Probably by opening issues, (ones that are using 23.08 of the baseapp)

If you don't have the time, I can reach out later.

ZVNexus commented 9 months ago

Probably by opening issues, (ones that are using 23.08 of the baseapp)

Done