search

flathub / org.electronjs.Electron2.BaseApp

7 stars 16 forks source link

Revert "Provide libsecret from shared modules for os_crypt" #57

Closed ZVNexus closed 8 months ago

ZVNexus commented 8 months ago

@bbhtt Related to this, is there a way I can trigger rebuilds for Slack if this gets merged without making a new commit to it's repo?

flathubbot commented 8 months ago

Started test build 100592

flathubbot commented 8 months ago

Build 100592 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/83374/org.electronjs.Electron2.BaseApp.flatpakref
bbhtt commented 8 months ago

No you can't, until this update is published, which happens 4-5 hours after the build from merge commit is done.

The issue could be related to this https://gitlab.gnome.org/GNOME/libsecret/-/issues/49#note_1307164, you can try testing with gcrypt disabled.

IIRC, a lot of electron applications depend on the deprecated node-keytar module and that doesn't work well with this.

ZVNexus commented 8 months ago

The issue could be related to this https://gitlab.gnome.org/GNOME/libsecret/-/issues/49#note_1307164, you can try testing with gcrypt disabled.

Tested with -Dcrypto=false, and the issue is no longer occurring. Is this an acceptable alternative to this revert, or is there something else that can be done?

bbhtt commented 8 months ago

No I suggest keeping it in, we already switched apps to using libsecret from baseapp. Apps that don't work can switch to disabling gcrypt.

The actual solution is of course for apps to switch to Electron's native keyring integration and for libsecret to fix the issue