search

flathub / org.electrum.electrum

https://flathub.org/apps/details/org.electrum.electrum
2 stars 8 forks source link

Update Request to 4.1.2 #27

Closed xscd closed 3 years ago

xscd commented 3 years ago

Current version on Flathub is 4.0.4 it would be great to get a bump to version 4.1.2

https://github.com/spesmilo/electrum/releases/tag/4.1.2

A6GibKm commented 3 years ago

Current is 4.0.9 I just forgot to update the metainfo. Thanks, since they dont do tagged releases there is no way for me to notice this, will try to update it soon.

xscd commented 3 years ago

Yeah since they don't do tagged releases its not possible to get notifications inside GitHub right? How do you manage to track those apps? https://github.com/spesmilo/electrum/releases.atom would RSS help?

A6GibKm commented 3 years ago

@xscd Could you test #28?

xscd commented 3 years ago

I tested #28 and noticed wayland is enabled by default and it causes crashes (upstream: https://github.com/spesmilo/electrum/issues/6542) where you wrote that it defaults to xorg (https://github.com/flathub/org.electrum.electrum/pull/17) but that wasn't the case. I had to disable wayland from flatseal to stop crashes. Other than that everything looks fine.

A6GibKm commented 3 years ago

Yes, I added Wayland support back some time ago since I was not able to reproduce said crashes after a certain update to QT or electrum. If you still have crashes I will remove the flag again, thanks for the feedback.

A6GibKm commented 3 years ago

@xscd I removed wayland support and will merge as soon as it build. Please test it and tell me if wayland was properly removed or if it needs further work.

xscd commented 3 years ago

Tested now I can create a new wallet without a crash (the crash happened when creating a new wallet and typing a password) Screenshot from 2021-04-26 01-11-33

Everything is fine now. One more thing that is left is to update the version metadata to 4.1.2 in flathub.

Screenshot from 2021-04-26 01-12-57

A6GibKm commented 3 years ago

Thanks, I always forget that. Should be fixed by #29

xscd commented 3 years ago

Thanks,everything is okay now. Feel free to close the issue. For future updates would the RSS enough for you to track new updates or would you mind me opening issues on the repository?

A6GibKm commented 3 years ago

The rss is fine, but sometimes I dont check it. Please feel free to open an issue if I dont update it in a timely fashion.