search

flathub / org.flameshot.Flameshot

https://flathub.org/apps/details/org.flameshot.Flameshot
3 stars 4 forks source link

Update runtime and harden permissions #19

Closed pm4rcin closed 9 months ago

pm4rcin commented 1 year ago

I have used flameshot without host permission for a while and I've tested that selecting a directory for screenshots works too. Also added fallback x11 to not escape sandbox on wayland.

Fixes https://github.com/flathub/org.flameshot.Flameshot/issues/21

flathubbot commented 1 year ago

Started test build 39122

flathubbot commented 1 year ago

Build 39122 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/21764/org.flameshot.Flameshot.flatpakref
bbhtt commented 1 year ago

cc @borgmanJeremy

borgmanJeremy commented 1 year ago

Hello, I am no longer the flameshot maintainer, but no one else has taken over. I am hesitant to merge this since as far as I know everything is working as is. When we did releases in the past we put a lot of effort into testing the flatpak on every support distro. It was important to test both X11 and Wayland, on basically each Distro, and each DE combination.

I will defer to @mmahmoudian if he wants to merge as is or do more testing.

bbhtt commented 1 year ago

It'd be nice to have the runtime update. The current runtime will reach EOL in August-September of this year.

Also, note that you can't use both --socket=x11 and --socket=wayland at the same time because the new linter will block that . If you want to use, you'll have to ask for an exception.

mmahmoudian commented 1 year ago

Thanks @borgmanJeremy for pinging me. It has been discussed that we should prepare for a release candidate. I will be in touch when we got to that stage (unless you also have some time to spare on this matter).

@bbhtt thanks for the tips. I will convey your points to the team. Cheers.

borgmanJeremy commented 11 months ago

@mmahmoudian this and #20 should be backported to the flatpak file in the main repo. I think both #19 and #20 should be merged after applying for the exception.

All flatpak users are currently getting an EOL warning until this is merged. I don't think it needs to be tied to a new release (IMO)

bbhtt commented 11 months ago

There shouldn't be a need to apply for the wayland exception anymore. That rule was moved to a warning from an error in the linter.

flathubbot commented 11 months ago

Started test build 72968

flathubbot commented 11 months ago

Build 72968 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/55625/org.flameshot.Flameshot.flatpakref
flathubbot commented 11 months ago

Started test build 73002

flathubbot commented 11 months ago

Build 73002 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/55659/org.flameshot.Flameshot.flatpakref
pm4rcin commented 11 months ago

From my testing things appear to work fine on sway.

bbhtt commented 11 months ago

What's the default location where flameshot saves screenshots? Right now it has no filesystem access but it needs at least something

flathubbot commented 11 months ago

Started test build 73883

flathubbot commented 11 months ago

Build 73883 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/56531/org.flameshot.Flameshot.flatpakref
Justinzobel commented 11 months ago

If this is stalled because of permission changes, can we please split the changes so that it's no longer on an EOL runtime at least?

pm4rcin commented 11 months ago

What's the default location where flameshot saves screenshots? Right now it has no filesystem access but it needs at least something

From my testing there's no default location but it asks for location to save and also you can choose default in settings because it works fine with portal.

bbhtt commented 11 months ago

From my testing there's no default location but it asks for location to save and also you can choose default in settings because it works fine with portal.

Thanks.

There is an option to choose a default location in config which always goes through the filechooser and seems work fine with the mounted path returned by the portal.

I've tested in on GNOME X11 and it seems to work. GNOME 45 wayland seems to broken on the latest release https://github.com/flameshot-org/flameshot/issues/3383, would be nice to have a new release.

cc @mmahmoudian, do you have anything? Your upstream PR needs updating, but you can merge this one.

pm4rcin commented 9 months ago

@mmahmoudian could you merge that one so people would stop seeing end of life notice on every update? It was tested on various DEs and WMs and works fine.

bbhtt commented 9 months ago

bot, build

flathubbot commented 9 months ago

Queued test build for org.flameshot.Flameshot.

flathubbot commented 9 months ago

Started test build 89927

flathubbot commented 9 months ago

Build 89927 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/72607/org.flameshot.Flameshot.flatpakref
bbhtt commented 9 months ago

I'm merging this, there has been no activity from the maintainers for months.

This at least does not introduce any issues.