search

flathub / org.flameshot.Flameshot

https://flathub.org/apps/details/org.flameshot.Flameshot
3 stars 4 forks source link

Still on v0.8.5 due to compiler error. #2

Closed Arcitec closed 3 years ago

Arcitec commented 3 years ago

@borgmanJeremy Hi, I noticed that flathub is still on 0.8.5. And I see that it's caused by the latest flatpak commit failing to build:

 * [new tag]         v0.9.0                -> v0.9.0
 * [new tag]         v0.9.0.rc1            -> v0.9.0.rc1
 * [new tag]         v0.9.0.rc2            -> v0.9.0.rc2
Failed to download sources: module flameshot: Git commit for branch (null) is 5690afbd4be857e20e0ff6f100c890a7250cccfe, but expected 856e08a019b8e9adc9f92ca24380940492ad172c
program finished with exit code 1
elapsedTime=5.807701

https://github.com/flathub/org.flameshot.Flameshot/commit/cbf0daacd0e5eaa7245878e60957f40e044bfecd

Try to remove the "commit" rule and build based on release tag instead, since flameshot clearly force-pushes and overwrites their own tags periodically to point at other commits.

borgmanJeremy commented 3 years ago

Thanks for pointing this out. I don't usually force push over tags on the main repo so I just fixed the SHA in this case. Can you show me where the build is failing so I can check that my change fixed it?

Edit: NVM I see the CI build now.

Arcitec commented 3 years ago

@borgmanJeremy Oh, I didn't notice that you're part of the official flameshot project. Awesome. Thanks for making a flatpak! And thanks a lot for making the best screenshot utility for linux! :)

And glad you found the CI log. I saw it on the https://github.com/flathub/org.flameshot.Flameshot/commits/master page by clicking on the red "X" at the v0.9.0 commit.

Well, thank you very much for fixing it! Awesome! ❤️