search

flathub / org.free_astro.siril

https://flathub.org/apps/details/org.free_astro.siril
4 stars 2 forks source link

restore opencv version #2

Closed lock042 closed 4 years ago

lock042 commented 4 years ago

I should write a PR . Sorry about the build issue.

flathubbot commented 4 years ago

Started test build 24319

hfiguiere commented 4 years ago

What is the reason of this?

lock042 commented 4 years ago

Looks like I broke the build with opencv: https://flathub.org/builds/#/builders/48/builds/2825

hfiguiere commented 4 years ago

I didn't realise you had pushed changes.

lock042 commented 4 years ago

Yes so stupid to push directly in master.

hfiguiere commented 4 years ago

I usually use pull request to have the build happen. At worse, I just make sure it builds locally. But even then sometime it is not enough.

lock042 commented 4 years ago

Yes, I should have used PR. I have to admit I don't understand why opencv4 is not taken into account, but I don't remember for Siril 0.9.12 version. Maybe it is normal.

flathubbot commented 4 years ago

Build 24319 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/23359/org.free_astro.siril.flatpakref
hfiguiere commented 4 years ago

likely because 4 is incompatible with 3.

lock042 commented 4 years ago

No I think they remove the pkgconfig file. They already did it in debian beore they've restored it.

lock042 commented 4 years ago

Something like that: https://github.com/opencv/opencv/issues/13154