flathub / org.freedesktop.LinuxAudio.BaseExtension

https://flathub.org/apps/details/org.freedesktop.LinuxAudio.BaseExtension
8 stars 2 forks source link

Update README.md for 23.08 #16

Closed runiq closed 3 months ago

runiq commented 3 months ago

The README was still referring to 22.08.

flathubbot commented 3 months ago

Started test build 143794

flathubbot commented 3 months ago

Build 143794 failed

abique commented 3 months ago

Actually isn't 24.08 out already?

bbhtt commented 3 months ago

Actually isn't 24.08 out already?

No

Build 143794 failed

You can create an empty share directory (install -d /app/share) and the error should be gone. I have added the necessary exceptions.

Having a metainfo file would be even better then files/share will automatically exist.

runiq commented 3 months ago

Having a metainfo file would be even better then files/share will automatically exist.

I'll have to read up on what to put in the metainfo of a base extension, but that sounds like a good idea.

runiq commented 3 months ago

@hfiguiere I'm trying to create the metainfo file; what license should I use?

hfiguiere commented 3 months ago

Having a metainfo file would be even better then files/share will automatically exist.

It was removed by barth in https://github.com/flathub/org.freedesktop.LinuxAudio.BaseExtension/commit/3dde70e4a0062dda6be4f3ba86c285b6eb1e97cd

hfiguiere commented 3 months ago

The only reason the base app exists is to have the extension point created before the build start.

hfiguiere commented 3 months ago

@hfiguiere I'm trying to create the metainfo file; what license should I use?

don't.

bbhtt commented 3 months ago

You still need to create an empty /app/share directory btw, otherwise the build will fail.

hfiguiere commented 3 months ago

You still need to create an empty /app/share directory btw, otherwise the build will fail.

This linter should be fixed. This package has "skip-appstream-check": true

bbhtt commented 3 months ago

We can't know if a directory exists if it's inside the ostree repo until it is checked out, but checking out a non existent directory will error. That comes from ostree.

bbhtt commented 3 months ago

The alternative is to checkout the root / instead of /files/share but that causes issues with large apps over 2 GB.