flathub / org.freedesktop.Platform.VulkanLayer.MangoHud

https://flathub.org/apps/details/org.freedesktop.Platform.VulkanLayer.MangoHud
18 stars 8 forks source link

23.08 branch #31

Closed tim77 closed 1 year ago

tim77 commented 1 year ago

Please branch new 23.08. com.valvesoftware.Steam already switched to new freedesktop 23.08 runtime.

rowbawts commented 1 year ago

Yes please due to the mismatch MangoHud is unusable to anyone who keeps their system updated.

gasinvein commented 1 year ago

Pushed 6bcf5143f98be0ca16703321ce7ffd73e66a4cd2, should be available soon.

@barthalion can you please make the branch branch/23.08 default?

rowbawts commented 1 year ago

I installed the new 23.08 based version and it's not loading into any games can anyone else confirm?

HanPrower commented 1 year ago

I can confirm that it's not working after the update...

Prodding mangohud returns an error

flatpak run --command="mangohud" --file-forwarding com.valvesoftware.Steam
bwrap: execvp mangohud: No such file or directory

Prodding the full path shows it works, so I guess it's a PATH issue somehow?

flatpak run --command="/usr/lib/extensions/vulkan/MangoHud/bin/mangohud" --file-forwarding com.valvesoftware.Steam
ERROR: No program supplied

Usage: mangohud <program>

I assume this is more a Flatpak Steam problem than a problem of this package, but I don't see an obvious commit that may have broken these sorts of extensions from working.

rowbawts commented 1 year ago

Ok so weird development, so as I began investigating by running Steam from the terminal I see it loading and reading the conf file normally. So I thought maybe somehow MangoHud is not able to see the keyboard shortcuts anymore (because I run no-display which hides MangoHud by default) so I commented that out and MangoHud is in fact loading/visible. It just can't be toggled with the default shortcut Shift+F12 anymore oddly.

@HanPrower btw I use MANGOHUD=1 as an env variable on Steam through Flatseal

Edit: nvm it isn't working, I got confused as I was testing Valheim that last attempt as it loads quickly (previously was testing with Dead Space). Valheim is a native Linux title so the issue is that for some reason MangoHud is no longer working in Proton titles.

gasinvein commented 1 year ago

Does it work for native Vulkan games, with MANGOHUD=1?

tim77 commented 1 year ago

Does it work for native Vulkan games, with MANGOHUD=1?

Doesn’t work with native Vulkan games. Tested on Quake II Remastered. EDIT: game using natively Vulkan but run via Proton (official Valve build).

tim77 commented 1 year ago
DEBUG:root:Addding /usr/lib/extensions/vulkan/gamescope/bin to PATH
DEBUG:root:Addding /usr/lib/extensions/vulkan/MangoHud/bin to PATH
tim77 commented 1 year ago

What i found is that MangoHud works fine with com.valvesoftware.Steam.CompatibilityTool.Proton community build. MangoHud doesn’t work only with official Proton, so something pressure-vessel related i guess.

gasinvein commented 1 year ago

So for some reason vulkan-loader inside the Steam Runtime container isn't picking up the flatpak'ed Vulkan layers. And for some reason it broke only on fd.o sdk 23.08? Maybe @nanonyme or @smcv has any idea what may be going on here?

smcv commented 1 year ago

So for some reason vulkan-loader inside the Steam Runtime container isn't picking up the flatpak'ed Vulkan layers. And for some reason it broke only on fd.o sdk 23.08? Maybe @nanonyme or @smcv has any idea what may be going on here?

Please open an issue in https://github.com/ValveSoftware/steam-runtime with steps to reproduce and I'll try to take a look.

barthalion commented 1 year ago

Pushed 6bcf514, should be available soon.

@barthalion can you please make the branch branch/23.08 default?

Done