flathub / org.freedesktop.Platform.VulkanLayer.MangoHud

https://flathub.org/apps/details/org.freedesktop.Platform.VulkanLayer.MangoHud
20 stars 7 forks source link

Update MangoHud 0.7.1 #42

Closed jntesteves closed 7 months ago

jntesteves commented 8 months ago

Update to MangoHud 0.7.1

Use the new build option introduced in this version to disable building mangoplot.

Revert bb26886fe9f2e96c367b599d7f9f736fd6a69017 from #35. It's been causing games to crash, confirmed with CS2 specifically, but I've had some other games crashing lately, and I believe this change could have been the cause all along. As it turns out, statically linking libstdc++ does matter even in Flatpak, because games are often executed under different runtimes, like the Steam runtimes.

Fixes bb26886fe9f2e96c367b599d7f9f736fd6a69017 Supersedes #39, #40, #41

flathubbot commented 8 months ago

Started test build 99570

flathubbot commented 8 months ago

Build 99570 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82361/org.freedesktop.Platform.VulkanLayer.MangoHud.flatpakref
slagiewka commented 8 months ago

This is interesting. 0.7.1 was supposed to fix https://github.com/flightlessmango/MangoHud/issues/1139

However, when 0.7.0 didn't crash CS2 for me (used with env not binary) 0.7.1, as shipped here, seems to crash for me with either method.

Loaded libSDL3.so.0, got 0x5563af7be170
Loaded /home/username/.var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/common/Counter-Strike Global Offensive/game/bin/linuxsteamrt64/libtier0.so, got 0x5563af66ece0
Loaded /home/username/.var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/common/Counter-Strike Global Offensive/game/bin/linuxsteamrt64/libfilesystem_stdio.so, got 0x5563af802ad0
Loaded /home/username/.var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/common/Counter-Strike Global Offensive/game/bin/linuxsteamrt64/libinputsystem.so, got 0x5563af803780
Loaded /home/username/.var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/common/Counter-Strike Global Offensive/game/bin/linuxsteamrt64/liblocalize.so, got 0x5563af86cf90
Loaded /home/username/.var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/common/Counter-Strike Global Offensive/game/bin/linuxsteamrt64/librendersystemvulkan.so, got 0x5563af86bec0
Loaded /home/username/.var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/common/Counter-Strike Global Offensive/game/bin/linuxsteamrt64/libresourcesystem.so, got 0x5563af8649d0
Loaded /home/username/.var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/common/Counter-Strike Global Offensive/game/bin/linuxsteamrt64/libschemasystem.so, got 0x5563af864f40
[2024-02-14 09:17:56.413] [MANGOHUD] [error] [overlay_params.cpp:1003] Failed to read presets file: '/home/username/.var/app/com.valvesoftware.Steam/config/MangoHud/presets.conf'
Fossilize INFO: Overriding serialization path: "/home/username/.var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/shadercache/730/fozpipelinesv6/steamapprun_pipeline_cache".
crash_20240214091756_2.dmp[1828]: Uploading dump (out-of-process)
/tmp/dumps/crash_20240214091756_2.dmp
/home/username/.var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/common/Counter-Strike Global Offensive/game/cs2.sh: line 118:  1786 Segmentation fault      (core dumped) ${STEAM_RUNTIME_PREFIX} ${GAME_DEBUGGER} "${GAMEROOT}"/${GAMEEXE} "$@"
crash_20240214091756_2.dmp[1828]: Finished uploading minidump (out-of-process): success = yes
crash_20240214091756_2.dmp[1828]: response: Discarded=1
crash_20240214091756_2.dmp[1828]: file ''/tmp/dumps/crash_20240214091756_2.dmp'', upload yes: ''Discarded=1''
pid 1828 != 1827, skipping destruction (fork without exec?)
jntesteves commented 8 months ago

This is interesting. 0.7.1 was supposed to fix flightlessmango/MangoHud#1139

However, when 0.7.0 didn't crash CS2 for me (used with env not binary) 0.7.1, as shipped here, seems to crash for me with either method.

I just tried CS2, and it crashes on launch for me on 0.7.1, but that seems unrelated to the fix for the issue you linked. The fix was simply to never change LD_PRELOAD in the mangohud command if the command line contains cs2.sh. It basically made the behavior of mangohud %command% identical to MANGOHUD=1 %command% for this game.

Whatever the issue we are having, it was introduced in this build of 0.7.1, as it doesn't happen on the previous version 0.7.0 for me either.

jntesteves commented 8 months ago

bot, build

flathubbot commented 8 months ago

Queued test build for org.freedesktop.Platform.VulkanLayer.MangoHud.

flathubbot commented 8 months ago

Started test build 99866

flathubbot commented 8 months ago

Build 99866 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82662/org.freedesktop.Platform.VulkanLayer.MangoHud.flatpakref
jntesteves commented 8 months ago

Latest build seems good to go. Doesn't crash for me in CS2 anymore.

Thanks @slagiewka for testing. I wouldn't have found this issue without your help.

slagiewka commented 8 months ago

Latest build seems good to go. Doesn't crash for me in CS2 anymore.

Thanks @slagiewka for testing. I wouldn't have found this issue without your help.

I can confirm it works now. Tested with CS2 and Overwatch 2.

Syntist commented 8 months ago

bot, build

flathubbot commented 8 months ago

Queued test build for org.freedesktop.Platform.VulkanLayer.MangoHud.

flathubbot commented 8 months ago

Started test build 102149

flathubbot commented 8 months ago

Build 102149 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/84929/org.freedesktop.Platform.VulkanLayer.MangoHud.flatpakref
TheJanzap commented 8 months ago

Could anyone with write access please merge this? I'd like to use MangoHud in CS2 again without any workarounds. Thanks :)

TheJanzap commented 7 months ago

Pinging previous contributor @gasinvein to merge this, but they haven't had any public activity since last November, so perhaps anyone else from the Flathub organisation could have a look?