flathub / org.freedesktop.Sdk.Extension.openjdk

10 stars 12 forks source link

Freedesktop SDK 24.08 will be dropping appstream-compose #53

Open bbhtt opened 3 months ago

bbhtt commented 3 months ago

Please remove manual compose or switch to appstreamcli

See https://docs.flatpak.org/en/latest/extension.html#extension-manifest for the commands

tsmock commented 3 months ago

FTR: https://github.com/flathub/org.freedesktop.Sdk.Extension.openjdk/blob/65dd5ab35dfeeb82870f37f32de47d213cb881fc/org.freedesktop.Sdk.Extension.openjdk.yaml#L198-L199

I think the following manifest changes will be needed:

build-options:
    prefix: $FLATPAK_DEST
    prepend-path: $FLATPAK_DEST/bin

With that said, it may also remove the need for the scripts: https://github.com/flathub/org.freedesktop.Sdk.Extension.openjdk/blob/65dd5ab35dfeeb82870f37f32de47d213cb881fc/org.freedesktop.Sdk.Extension.openjdk.yaml#L166-L189

I'm not certain. In any case, I'll probably want to wait to remove the scripts until after the next "major" bump (23.08 -> 24.08).

@bbhtt: I've got a couple of questions.

bbhtt commented 3 months ago

FTR:

https://github.com/flathub/org.freedesktop.Sdk.Extension.openjdk/blob/65dd5ab35dfeeb82870f37f32de47d213cb881fc/org.freedesktop.Sdk.Extension.openjdk.yaml#L198-L199

You need to change only this part. Either drop this line and drop appstream-compose: false from the top then the thing happens automatically.

If automatic doesn't work, keep them and change it to:

appstreamcli compose --components=${FLATPAK_ID} --prefix=/ --origin=${FLATPAK_ID} --result-root=${FLATPAK_DEST} --data-dir=${FLATPAK_DEST}/share/app-info/xmls ${FLATPAK_DEST} for composing with appstreamcli