search

flathub / org.freedesktop.Sdk.Extension.php73

0 stars 2 forks source link

Various Improvements #1

Closed p1u3o closed 5 years ago

p1u3o commented 5 years ago

I've been using my own PHP manifest for quite a few months and would rather use this one, so I've added some changes onto this extension that should make it a lot better to use with VSCode and other Flatpak IDEs.

Edits is on so please adjust as you see fit.

Added

Updated

Fixed

flathubbot commented 5 years ago

Started test build 5801

flathubbot commented 5 years ago

Build 5801 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/5573/org.freedesktop.Sdk.Extension.php73.flatpakref
flathubbot commented 5 years ago

Started test build 5802

flathubbot commented 5 years ago

Build 5802 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/5574/org.freedesktop.Sdk.Extension.php73.flatpakref
flathubbot commented 5 years ago

Started test build 5811

flathubbot commented 5 years ago

Build 5811 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/5583/org.freedesktop.Sdk.Extension.php73.flatpakref
flathubbot commented 5 years ago

Started test build 5812

flathubbot commented 5 years ago

Build 5812 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/5584/org.freedesktop.Sdk.Extension.php73.flatpakref
flathubbot commented 5 years ago

Started test build 5815

flathubbot commented 5 years ago

Build 5815 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/5586/org.freedesktop.Sdk.Extension.php73.flatpakref
flathubbot commented 5 years ago

Started test build 5825

flathubbot commented 5 years ago

Build 5825 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/5596/org.freedesktop.Sdk.Extension.php73.flatpakref
flathubbot commented 5 years ago

Started test build 5826

flathubbot commented 5 years ago

Build 5826 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/5598/org.freedesktop.Sdk.Extension.php73.flatpakref
p1u3o commented 5 years ago

I don't think PHP license is needed in this repo. It's already referenced in the appdata.

I was interpreting this line here.

https://github.com/php/php-src/blob/master/LICENSE#L13 seemed like a valid reason to put the license in with the sdk.

The MIT has something similar https://github.com/composer/composer/blob/master/LICENSE#L10

Even if my interpretation is wrong, I don't think there's any harm in bundling it.

gasinvein commented 5 years ago

IANAL, but it seems like to fulfill this condition you have to include the licence into the flatpak bundle, e.g. put it somewhere in /usr/lib/sdk/php73/. This repo doesn't actually contain PHP.

p1u3o commented 5 years ago

It's gets copied into /usr/lib/sdk/php73

I agree it's not needed in the repository, I could adjust the manifest to copy the licenses from their respective sources, copying Fedora's FHS, placing them in /usr/lib/sdk/php73/share/licenses/, e.g. the Composer RPM installs /usr/share/licenses/composer/LICENSE (which itself is a symlink to /usr/share/composer/license).

flathubbot commented 5 years ago

Started test build 5854

p1u3o commented 5 years ago

Updated this branch.

Fixed libzip not being used, thus --with-libzip not doing anything Licenses are now fetched and included at build time from their respective sources. Fixed cleanup not including the php manpages.

flathubbot commented 5 years ago

Started test build 5855

flathubbot commented 5 years ago

Started test build 5856

flathubbot commented 5 years ago

Build 5854 was cancelled

flathubbot commented 5 years ago

Build 5855 was cancelled

flathubbot commented 5 years ago

Build 5856 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/5627/org.freedesktop.Sdk.Extension.php73.flatpakref