search

flathub / org.freedesktop.appstream.cli

https://flathub.org/apps/details/org.freedesktop.appstream.cli
0 stars 1 forks source link

Update to 1.0 #5

Closed ximion closed 10 months ago

flathubbot commented 10 months ago

Started test build 81120

flathubbot commented 10 months ago

Build 81120 failed

ximion commented 10 months ago

Flatpak builder seems to be complaining about missing screenshots... - but this is a console application, there are no screenshots! A bit ironic that this seems to fail due to AppStream issues. @barthalion or @razzeee do you know what's going on here? I also seem to get an error about missing icons, but for this console application, skip-icons-check is set to true, so there shouldn't be an error.

razzeee commented 10 months ago

I'm not sure, but the website itself only lists console apps, if they have an icon and at least one screenshot. Barth might have build that check additionally somewhere into the pipelines, but I'm not sure.

ximion commented 10 months ago

I'm not sure, but the website itself only lists console apps, if they have an icon and at least one screenshot.

That doesn't seem to be the case: https://flathub.org/apps/org.freedesktop.appstream.cli

This also built just fine before, so this change does not make much sense to me... (at least not for anything that isn't a desktop-application component).

razzeee commented 10 months ago

While it gets a page (probably more of a bug), it's not added to the search and other places

ximion commented 10 months ago

Screenshots make no sense here at all... I could maybe add an icon though. Should this be a blocker though to add console-application apps? This would affect a lot of stuff I'd imagine (like compilers and other things), and while it's probably fair to not display applications without icon in the store pages, excluding them from the repository entirely (especially since they are already in there) feels like it's a bit of an overreaction.

razzeee commented 10 months ago

I don't think this was meant to work like this, so it's probably a bug - let's wait for Barth

barthalion commented 10 months ago

bot, build

flathubbot commented 10 months ago

Queued test build for org.freedesktop.appstream.cli.

flathubbot commented 10 months ago

Started test build 82622

flathubbot commented 10 months ago

Build 82622 failed

barthalion commented 10 months ago

I need to poke around, but yes, this is a regression on our end.

flathubbot commented 10 months ago

Started test build 82631

flathubbot commented 10 months ago

Build 82631 failed

barthalion commented 10 months ago

bot, build

flathubbot commented 10 months ago

Queued test build for org.freedesktop.appstream.cli.

flathubbot commented 10 months ago

Started test build 82643

flathubbot commented 10 months ago

Build 82643 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/65273/org.freedesktop.appstream.cli.flatpakref
ximion commented 10 months ago

Nice, thank you for the quick fix! Looks like the Flathub JSON file needs to be installed as well now? @barthalion Is this safe to merge, or should I wait a bit? :-)

barthalion commented 10 months ago

Yeah, it's good to go.

ximion commented 10 months ago

Yeah, it's good to go.

Excellent :-) This bundle is a pretty nice way for people to validate with newer AS versions (and use compose too!).