search

flathub / org.freefilesync.FreeFileSync

https://flathub.org/apps/details/org.freefilesync.FreeFileSync
102 stars 19 forks source link

use extra-data step to download FFS binary #49

Closed kparal closed 3 years ago

kparal commented 3 years ago

The binary license doesn't permit redistribution if the original archive is adjusted. Instead, download it as the extra-data step, i.e. during installation on the user's machine. This doesn't violate its license.

Fixes: https://github.com/flathub/org.freefilesync.FreeFileSync/issues/48

flathubbot commented 3 years ago

Started test build 40148

flathubbot commented 3 years ago

Build 40148 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/38639/org.freefilesync.FreeFileSync.flatpakref
flathubbot commented 3 years ago

Started test build 40149

flathubbot commented 3 years ago

Build 40149 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/38640/org.freefilesync.FreeFileSync.flatpakref
kparal commented 3 years ago

@Garbulix and anyone else interested, testing the installation using the instructions above is very appreciated, thanks.

Garbulix commented 3 years ago

I will check later this week :)

kparal commented 3 years ago

OK. I'm quite confident it works, and I have more patches in the queue, so I'll merge it right away.

kparal commented 3 years ago

So the test build worked fine for me:

Build 40149 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/38640/org.freefilesync.FreeFileSync.flatpakref

And the final build errors out during installation with:

Error: Error deploying: While trying to apply extra data: apply_extra script failed, exit status 512 error: Failed to install org.freefilesync.FreeFileSync: Error deploying: While trying to apply extra data: apply_extra script failed, exit status 512

Great.

kparal commented 3 years ago

I created #53 to track the installation issue.