flathub / org.geany.Geany

https://flathub.org/apps/details/org.geany.Geany
6 stars 6 forks source link

Missing Geany Plugins #1

Closed kafran closed 11 months ago

kafran commented 6 years ago

The Geany Plugins are missing. Geany without plugins is useless.

TingPing commented 6 years ago

The repo full of plugins btw: https://github.com/geany/geany-plugins

It is probably reasonable to package most of them, they are disabled by default and they shouldn't have any dependencies.

kafran commented 6 years ago

SpellCheck and LineOperations are a must have.

prcastro commented 6 years ago

I would welcome a PR for this feature. It should be basically add geany-plugins to the sources, I think. Of course it would have to be tested locally, but the needed changes are minimal.

btreut commented 1 year ago

What is the current state of this issue? I arrived here after searching desperately for a flatpacked version of the geany-plugins for EndlesssOS.

TingPing commented 1 year ago

@btreut Somebody opened a draft PR (linked above) but didn't finish it. Feel free to pick it up and submit a patch.

btreut commented 1 year ago

@TingPing I fear that I am not knowledgeable enough to do that.

TiZ-HugLife commented 11 months ago

Okay, so I decided to revisit this since Geany 2.0 came out. After adding just the tarball to the manifest, most of the plugins do appear. The ones that are missing, and what they depend on, are:

The readme mentions a gtkspell plugin that doesn't exist in the source tree anymore, and a peg-markdown plugin that seems like it might just be an alternative backend for the markdown plugin.

Anyways, to resolve all those deps, I pilfered a lot of snippets from all over the Flathub org here on github. :)

WebkitGTK by itself makes everything so much more of a pain that I split its part of the manifest off into its own file. And then I ended up splitting the geany plugins module itself into its own file since I figured I might as well. Now I have to wait three million years for WebkitGTK itself to build to see if this venture worked.

If it all works out okay, I am perfectly okay with bundling geany-plugins with this Flatpak if the rest of you are. It may be more technically correct to make extensions, but have you seen how many plugins there are? Doing it correctly seems like a gargantuan undertaking that will make this package considerably more of a pain to maintain.

btreut commented 11 months ago

Okay, so I decided to revisit this since Geany 2.0 came out.

@HugLifeTiZ thanks a lot. Sorrily, I do not remember which plugin I missed in March. Is your plugin flatpak available from standard flathub or from some test repo or better: how can I try it?

TiZ-HugLife commented 11 months ago

I'm not done with it yet. As it stands, it will not be a separate Flatpak installation, it will just be included in the regular Flatpak package. All the plugins install as library files inside /app/lib/geany, including the built-in plugins, so I'm not sure if there's a good way to separate them out that fits with Flatpak's extension system. And that's presuming they don't ship any extra data. It may be controversial to make Geany suddenly grow the size of WebkitGTK + extras, but the niche of specifically minimalistic GTK3 editors is fulfilled by Mousepad already, so it makes sense to pivot Geany into the niche of a highly extensible GTK3 editor, where it was meant to be all along anyways.

If there is in fact a clean way to do this with the extension system, I'd be willing to do it that way. But I absolutely will not maintain an extension for every individual plugin. It has to be the built-in plugins together, and the geany-plugins package together. (I could see a case for splitting Markdown and Webhelper into a "WebkitGTK Plugins" package because it is so chunky and such a huge pain to build.)

But it's all moot because I'm tripping on the plugins that depend on WebkitGTK anyways (markdown and webhelper). I spend roughly 3 million years building WebkitGTK only for those two plugins to still not appear. I have to try and figure out why that is. But I'd rather ship Geany-Plugins without WebkitGTK than not ship it at all, so I'm only gonna give myself a little time for that.

btreut commented 11 months ago

I'm not done with it yet. As it stands, it will not be a separate Flatpak installation, it will just be included in the regular Flatpak package

Ok. I think integrating the plugins into the main flatpak is reasonable. Take all the time you need.

btreut commented 10 months ago

thanks a lot. Looks good, compared to 6 days ago I see now lots of plugins in the plugin manager

TiZ-HugLife commented 10 months ago

No problem. I found out that three of them are still not working for various reasons, and I've been working on fixing it. (WebkitGTK takes forever to build.) I'll push out a new version soon with all plugins available.

tim77 commented 10 months ago

WebkitGTK takes forever to build

ccache doesn't help much?

flatpak run org.flatpak.Builder --ccache
TiZ-HugLife commented 10 months ago

WebkitGTK takes forever to build doesn't help much?

flatpak run org.flatpak.Builder --ccache

Wait, it doesn't do that by default? That's weird. Thanks for the tip!

TingPing commented 10 months ago

Wait, it doesn't do that by default? That's weird.

Well if you aren't constantly rebuilding from the same builddir you are just wasting space. WebKit is one of the few places it would be really helpful.