search

flathub / org.geeqie.Geeqie

https://flathub.org/apps/details/org.geeqie.Geeqie
0 stars 2 forks source link

GTK3 Disabled? #16

Closed yourealwaysbe closed 2 years ago

yourealwaysbe commented 2 years ago

I notice in b7ce1ded11c0aa35dc19dc63d0f34f74066b5fdd the GTK version was downgraded from 3 to 2. GTK3 would provide native Wayland support. Is there a particular reason it was removed?

Hofer-Julian commented 2 years ago

See https://github.com/flathub/org.geeqie.Geeqie/pull/4

yourealwaysbe commented 2 years ago

Great, thanks.

Is it still buggy? GTK 2 received it's EOL in Dec 2020. I've had no issues with the GTK3 version over the past few years, but i'm a fairly light user.

Hofer-Julian commented 2 years ago

Feel free to update the manifest to gtk3 in a PR and test if the bug has been fixed :)

If it's fixed, I will merge it.

yourealwaysbe commented 2 years ago

Hah, thought you might say that :) I'll have a go once i learn how to do something more than just "flatpak install".

Hofer-Julian commented 2 years ago

Doing more or less the reverse of https://github.com/flathub/org.geeqie.Geeqie/pull/4/files should do it. If you need help, let me know

yourealwaysbe commented 2 years ago

Thanks. Trying now, but failing with

Package 'clutter-1.0', required by 'virtual:world', not found

I have clutter 1.26.4 installed natively (Arch Linux). Should i expect it to be finding it, or do i need to do something flatpaky about missing deps?

edit: running:

flatpak-builder build org.geeqie.Geeqie.json
paperdigits commented 2 years ago

Clutter needs to be available inside the flatpak sandbox.

On July 7, 2022 1:04:44 PM PDT, yourealwaysbe @.***> wrote:

Thanks. Trying now, but failing with

Package 'clutter-1.0', required by 'virtual:world', not found

I have clutter 1.26.4 installed natively (Arch Linux). Should i expect it to be finding it, or do i need to do something flatpaky about missing deps?

-- Reply to this email directly or view it on GitHub: https://github.com/flathub/org.geeqie.Geeqie/issues/16#issuecomment-1178162789 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

caclark commented 2 years ago

Clutter is not a requirement for running Geeqie with GTK3. Clutter is required only for gpu-accel and the GPS map. I am not sure how this affects a flatpak installation, but for a standard installation the command is: ./autogen.sh --disable-gpu-accel

Hofer-Julian commented 2 years ago

@yourealwaysbe just open a PR with what you have and we can look there.

yourealwaysbe commented 2 years ago

Thanks, in the end i updated the shared modules and added clutter. PR made, though needs testing.