Open A6GibKm opened 3 years ago
If merged, please consider applying this changes upstream.
Started test build 29913
Build 29913 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/28805/org.gnome.Boxes.flatpakref
@bilelmoussaoui Relevant after updating to 3.38. It will also provide the new tracker which is nice
Could you please drop commit eb92c1f9ce2ef229b06b60d22d5be3dc50b1b5ba from this PR?
Thank you very much.
Started test build 30675
Sorry about that, done. I am pretty sure this won't build, maybe it should be rebased on top of the 3.38.1 PR?
Build 30675 failed
Started test build 30836
Rebased.
Build 30836 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/29707/org.gnome.Boxes.flatpakref
Now I am debugging why GSettings/GLib won't pick up org.gnome.desktop.input-sources
used by Boxes[0] throughout the Flatpak Settings portal.
Back when the dconf keyfile migration was starting to happen, I proposed [1] and [2]. So GLib should be able to pick it up from the portal automagically. :)
Unfortunately, that doesn't seem to be working for Boxes.
To verify, you need to compare the output of the command below in the host:
gsettings get org.gnome.desktop.input-sources sources
With the output of the same command within the app's sandbox:
flatpak --command=bash run org.gnome.Boxes//test
gsettings get org.gnome.desktop.input-sources sources
In my system, the sources list returned inside the sandbox is empty. It should be identical to what you get on the host.
Btw, this is similar to when I got this PR https://github.com/flathub/org.gnome.Boxes/pull/47.
[0] https://gitlab.gnome.org/GNOME/gnome-boxes/blob/master/src/unattended-installer.vala#L670 [1] https://github.com/flatpak/xdg-desktop-portal/pull/367 [2] https://github.com/flatpak/xdg-desktop-portal-gtk/pull/232
Thanks for the precise information, you are right. I am getting
@a(ss) []
Inside the sandbox, which is certainly different than
[('xkb', 'us+altgr-intl')]
See https://github.com/flathub/flathub/issues/1040, this is not allowed by the flathub linter anymore. If this is still an issue we might need to request an exception.
All existing ones already got exceptions.
Unlike the prior PR #47, this adds the proper path for the gschema. Fixes #45.
Had to use 3.38.0 as 3.38.1 would not compile due to the Tracker1 to Tracker3 migration.
Tested: