search

flathub / org.gnome.Boxes

https://flathub.org/apps/details/org.gnome.Boxes
13 stars 10 forks source link

[WIP] Add x-checker-data #63

Closed proletarius101 closed 3 years ago

proletarius101 commented 3 years ago

Does it use the git version and not the released one?

Not true. I select the tagged versions. Some reason as https://github.com/flathub/org.gnome.Evince/pull/37#issuecomment-781910919 They are simply hosted on GitLab, but they have the same version (as their tags) as the ones hosted on the website. I don't use the ones on download.gnome.org because the urls don't compatible with the x-checker-data. e.g.

                     "url": "https://download.gnome.org/sources/gspell/1.8/gspell-1.8.4.tar.xz",

There is a 1.8 in the middle. But what if the version bumps to 1.9.x? We don't have a procedure to provide the substring 1.9.

flathubbot commented 3 years ago

Started test build 39669

flathubbot commented 3 years ago

Build 39669 failed

flathubbot commented 3 years ago

Started test build 39672

flathubbot commented 3 years ago

Build 39672 failed

barthalion commented 3 years ago

I disagree with random bumps of random modules, and this is essentially what adding x-data-checker accomplishes here. This is fine if an upstream maintainer decides to do so, but not so much if it's done via drive-through contribution.

felipeborges commented 3 years ago

Yes. I agree with @barthalion.

Although we are proposing automatic updates for our osinfo-db https://github.com/flathub/org.gnome.Boxes.Extension.OsinfoDb/pull/2 where I think this makes sense, since this is just a database, and the project has strong CI. For libraries/modules, I don't think that brings us any practical benefits now.