flathub / org.gnome.Calendar

Gnome Calendar
https://flathub.org/apps/details/org.gnome.Calendar
1 stars 9 forks source link

Update to GNOME runtime 40 #29

Closed A6GibKm closed 3 years ago

A6GibKm commented 3 years ago

Some module were not updated, e.g. libgweather as the compiler complained.

bilelmoussaoui commented 3 years ago

bot, build

flathubbot commented 3 years ago

Queued test build for org.gnome.Calendar.

flathubbot commented 3 years ago

Started test build 43014

flathubbot commented 3 years ago

Build 43014 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/41382/org.gnome.Calendar.flatpakref
X-m7 commented 3 years ago

Some module were not updated, e.g. libgweather as the compiler complained.

What was the issue here? I tried your branch plus libgweather 40.0 locally and it compiles. Granted, the weather part doesn't seem to actually work (GWeather-CRITICAL **: 09:34:32.217: gweather_info_update: assertion 'info->contact_info != NULL' failed in the terminal, and no weather info appears), but otherwise it looks fine to me.

A6GibKm commented 3 years ago

Ugh, it just said that meson was not supported or something like that (?), I did not look much into it to be honest. The other modules were mostly me not knowing what else required an update.

X-m7 commented 3 years ago

You might want to try updating your flatpaks I suppose, in case there was an update to the SDK or something. Anyway, some of the other dependencies have updates too, so I've sent a PR to your fork for that (linked below this comment)

go-ten commented 3 years ago

Hi,

Any news about this PR ?

bilelmoussaoui commented 3 years ago

Some module were not updated, e.g. libgweather as the compiler complained.

What was the issue here? I tried your branch plus libgweather 40.0 locally and it compiles. Granted, the weather part doesn't seem to actually work (GWeather-CRITICAL **: 09:34:32.217: gweather_info_update: assertion 'info->contact_info != NULL' failed in the terminal, and no weather info appears), but otherwise it looks fine to me.

lt depends on whether Calendar was updated to use the new libgweather 40 API or not.

X-m7 commented 3 years ago

lt depends on whether Calendar was updated to use the new libgweather 40 API or not.

According to this it's been updated enough to compile at least, which it does on my machine.

bilelmoussaoui commented 3 years ago

@A6GibKm do you mind bumping libgweather & goa as well?

flathubbot commented 3 years ago

Started test build 43778

flathubbot commented 3 years ago

Build 43778 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/42122/org.gnome.Calendar.flatpakref
A6GibKm commented 3 years ago

@bilelmoussaoui I am not able to build goa. Seems whatever they do in the flatpak manifest upstream uses master features which are not even in 3.9.

X-m7 commented 3 years ago

I am not able to build goa. Seems whatever they do in the flatpak manifest upstream uses master features which are not even in 3.9.

Which version did you try? The latest release is 3.38.1 still, that again compiles fine on my system. There is a 3.40 branch on GItLab but they haven't actually tagged a release from it yet.

A6GibKm commented 3 years ago

I tried using 3.8.5 without success.

X-m7 commented 3 years ago

I tried using 3.8.5 without success.

Makes sense, that was all the way back from 2013, easy mistake to make if you were just scrolling through https://download.gnome.org/sources/gnome-online-accounts/.

flathubbot commented 3 years ago

Started test build 43799

A6GibKm commented 3 years ago

I found the issue.... I was using 3.8 rather than 3.38..

flathubbot commented 3 years ago

Build 43799 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/42142/org.gnome.Calendar.flatpakref
flathubbot commented 3 years ago

Started test build 43878

flathubbot commented 3 years ago

Build 43878 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/42216/org.gnome.Calendar.flatpakref
bilelmoussaoui commented 3 years ago

Lgtm, thanks!