search

flathub / org.gnome.Photos

https://flathub.org/apps/details/org.gnome.Photos
1 stars 5 forks source link

Update to 3.30.1 #5

Closed uajain closed 5 years ago

uajain commented 5 years ago

There's a small problem:

Even though there is no changes for the liboauth module, I encounter a build failure there as : https://paste.gnome.org/pehehvrqg

I don't get this build failure on master's manifest.

Looking closely, there is an addition -fstack-protector-strong flag coming in. I don't see this flag configured while building master's manifest. I don't know from where it's coming from.

@debarshiray Can you take a quick look?

phako commented 5 years ago

TL;DR: liboauth does not compile against OpenSSL 1.1, switch to NSS.

See your own history: https://gitlab.gnome.org/GNOME/gnome-photos/commit/886d93bf2542fcddf7b7cae56dee20254e26b945

debarshiray commented 5 years ago

I already merged the bit about switching grilo to Meson.

Thanks for working on this!

uajain commented 5 years ago

Libraw has a patch in the tree. That's why I didn't touch the modules which requires a patch,

phako commented 5 years ago

The patch applies cleanly to 0.19.0, FWIW

debarshiray commented 5 years ago

Ok, pushed the LibRaw update as commit 915519171e2874e6.

nedrichards commented 5 years ago

bot, build

debarshiray commented 5 years ago

bot, build

Success: https://flathub.org/builds/#/builders/2/builds/5129 !

debarshiray commented 5 years ago

I stuck the URL of this PR in the commit message and merged. Thanks, everybody!