flathub / org.gnome.Polari

https://flathub.org/apps/details/org.gnome.Polari
3 stars 2 forks source link

does not persist logs across sessions #5

Closed andreasn closed 5 years ago

andreasn commented 5 years ago

It seems that logs do not persist across sessions (like for example when I have to reboot my machine to apply OS updates). ~/.var/app/org.gnome.Polari/data is supposed to have a TPLogger folder, but it doesn't seem to be there.

fmuellner commented 5 years ago

~/.var/app/org.gnome.Polari/data is supposed to have a TPLogger folder

No, the logs are expected in the regular ~/.local/share/TpLogger folder, for various reasons:

What's the output of

$ flatpak run --command=ls org.gnome.Polari -ld .local/share/TpLogger

We used to rely on telepathy-logger on the host, so only request read-only access to the logs. However that was addressed a while ago, so it shouldn't be the issue here.

andreasn commented 5 years ago

This is what I get: ls: cannot access '.local/share/TpLogger': No such file or directory Version is 3.30.2

fmuellner commented 5 years ago

Oh, I may have an idea what's going on. The folder doesn't exist outside the sandbox either, does it?

andreasn commented 5 years ago

Indeed, it doesn't.

fmuellner commented 5 years ago

Can you please try the test build in the pull request?

fmuellner commented 5 years ago

Some testing suggests that the patch indeed fixes the issue. I therefore went ahead and included it in the 3.31.91 release, which is also available in the flathub beta channel.

Can you confirm that either the build for this PR or the beta version is working for you now?

andreasn commented 5 years ago

Tested 3.31.91 and now it works! Thank you!

fmuellner commented 5 years ago

Awesome, pushed the fix to stable as well then.