search

flathub / org.gnome.Totem.Devel

0 stars 2 forks source link

Include most of gst-plugins-bad, including gstopenh264, in main app #28

Open wjt opened 11 months ago

wjt commented 11 months ago

As outlined in the two commit messages, this doesn't increase the encumbered-codec surface area of the main app because all this code is already present in its dependent runtime, if only it would use the system gstreamer.

This change makes it possible to decode many more videos on systems which do not have the .Codecs extension installed, but one or both of the openh264 extension or VAAPI drivers. (There are be contexts where distributors or users are comfortable installing these but not the full bundle of fancy codecs.)

Fixes https://github.com/flathub/org.gnome.Totem.Devel/issues/25

flathubbot commented 11 months ago

Started test build 79694

flathubbot commented 11 months ago

Build 79694 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/62305/org.gnome.Totem.Devel.flatpakref
wjt commented 11 months ago

I have verified that with at least one of the following installed:

My sample video can be played back. However the snag is that if you remove all three, libgstopenh264 segfaults. I'll look into:

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5581 looks highly relevant…

flathubbot commented 11 months ago

Started test build 79715

flathubbot commented 11 months ago

Build 79715 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/62326/org.gnome.Totem.Devel.flatpakref