emacs-libvterm install fails - compile with --with-modules?

fapdash commented 3 years ago

Would it be possible to add the --with-modules flag to the build so we can use emacs-libvterm?

Error

Error (use-package): vterm/:catch: VTerm needs module support.  Please compile Emacs with
  the --with-modules option!
Error (use-package): multi-vterm/:catch: VTerm needs module support.  Please compile Emacs with
  the --with-modules option!

Related to #32

muep commented 2 years ago

Hi @fapdash , the NEWS document in Emacs states that the support for dynamic modules should already be enabled by default. I wonder if you or someone else has already tried adding the flag. Sometimes build error messages are produced by logic that assumes a wrong reason for failing to build.

muep commented 2 years ago

@fapdash , could you check with your installation steps:

With the main build that flathub normally ships, once the version from #42 lands in your updates. This is to check if simply updating the runtime happens the change things for your package.
If the current version does not work, try the build from #44

fapdash commented 1 year ago

Okay, module support is activated now by default but the installation still fails. The libvterm compilation that's part of the installation fails, to be more precise. I guess this has something to do with the sandbox nature of flatpak?

-- The C compiler identification is GNU 12.1.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- No build type selected, defaulting to RelWithDebInfo
-- System libvterm not found: libvterm will be downloaded and compiled as part of the build process
-- Configuring done
-- Generating done
-- Build files have been written to: /home/fap/temp/.emacs.d/elpa/vterm-20220831.835/build
[  8%] Creating directories for 'libvterm'
[ 16%] Performing download step (git clone) for 'libvterm'
Cloning into 'libvterm'...
HEAD is now at 15133bb ssage: Version bump to v0.2
[ 25%] Performing update step for 'libvterm'
[ 33%] No patch step for 'libvterm'
[ 41%] No configure step for 'libvterm'
[ 50%] Performing build step for 'libvterm'
TBL src/encoding/DECdrawing.tbl
TBL src/encoding/uk.tbl
CC src/encoding.c
CC src/keyboard.c
CC src/mouse.c
CC src/parser.c
CC src/pen.c
CC src/screen.c
CC src/state.c
CC src/unicode.c
src/unicode.c:306:12: warning: ‘mk_wcswidth_cjk’ defined but not used [-Wunused-function]
  306 | static int mk_wcswidth_cjk(const uint32_t *pwcs, size_t n)
      |            ^~~~~~~~~~~~~~~
src/unicode.c:215:12: warning: ‘mk_wcswidth’ defined but not used [-Wunused-function]
  215 | static int mk_wcswidth(const uint32_t *pwcs, size_t n)
      |            ^~~~~~~~~~~
CC src/vterm.c
LINK libvterm.la
CC bin/unterm.c
CC bin/vterm-ctrl.c
CC bin/vterm-dump.c
[ 58%] No install step for 'libvterm'
[ 66%] Completed 'libvterm'
[ 66%] Built target libvterm
[ 75%] Building C object CMakeFiles/vterm-module.dir/vterm-module.c.o
[ 83%] Building C object CMakeFiles/vterm-module.dir/utf8.c.o
[ 91%] Building C object CMakeFiles/vterm-module.dir/elisp.c.o
make[2]: *** No rule to make target 'libvterm-prefix/src/libvterm/.libs/libvterm.a', needed by '/home/fap/temp/.emacs.d/elpa/vterm-20220831.835/vterm-module.so'.  Stop.
make[1]: *** [CMakeFiles/Makefile2:86: CMakeFiles/vterm-module.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

flathub / org.gnu.emacs

emacs-libvterm install fails - compile with --with-modules? #40

Error