search

flathub / org.godotengine.Godot

Godot engine
https://flathub.org/apps/details/org.godotengine.Godot
38 stars 24 forks source link

Also package git? #103

Open TobTobXX opened 2 years ago

TobTobXX commented 2 years ago

VCS doesn't work inside the flatpak, because the git binary is missing I think.

What's the opinion on packaging it?

Calinou commented 2 years ago

What's the opinion on packaging it?

It might be better to patch the VCS library to allow using a custom Git command and arguments, so flatpak-run can be used instead to call system Git.

lw64 commented 1 year ago

I think the best way would be to use use org.freedesktop.Sdk as the flatpak runtime. It includes among other useful things also git. A lot of other development oriented apps also use sdks as the runtime, so this is 100% supported. I think the godot flatpak should rely as little as possible on certain executables on the host. It needs to be set up before it works and also installing something like git is not possible (or not recommended) on read-only operating systems like for example fedora silverblue.

Zishan-Rahman commented 1 month ago

Now that we're using org.freedesktop.Sdk as the Flatpak runtime now, Git with Godot hopefully should work, and if it does work then we can close this issue, but I haven't tested this in a long while. Until I get to that, if anyone else wants to try this out, I'm more than happy for you to do so :+1: