flathub / org.godotengine.Godot

Godot engine
https://flathub.org/apps/details/org.godotengine.Godot
37 stars 23 forks source link

Append java executables to PATH based on JAVA_HOME #152

Closed j20001970 closed 8 months ago

j20001970 commented 8 months ago

When exporting to Android, package signing will fail if Java executables is not in PATH, even when JAVA_HOME is set. Exporting with Use Gradle Build enabled seems not affected by this.

This PR simply source the enable.sh provided by OpenJDK SDK extension that will append $JAVA_HOME/bin to PATH before running Godot editor. By locating the path based on JAVA_HOME, users can override the path if different OpenJDK version is installed.

flathubbot commented 8 months ago

Started test build 90991

flathubbot commented 8 months ago

Build 90991 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/73674/org.godotengine.Godot.flatpakref
flathubbot commented 8 months ago

Started test build 91176

flathubbot commented 8 months ago

Build 91176 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/73855/org.godotengine.Godot.flatpakref
flathubbot commented 8 months ago

Started test build 91192

flathubbot commented 8 months ago

Build 91192 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/73871/org.godotengine.Godot.flatpakref