search

flathub / org.godotengine.Godot

Godot engine
https://flathub.org/apps/details/org.godotengine.Godot
39 stars 25 forks source link

Use Java from the official Freedesktop Sdk Extension #155

Closed priahoud closed 9 months ago

priahoud commented 9 months ago

151 and #152 broke the build pipeline for Android by completely removing the Java Sdk Extension from the manifest and therefore Java from the build.

It was instead replaced by an environment variable JAVA_HOME pointing to a now non-existing directory ("/usr/lib/sdk/openjdk17", which is only accessible at build time or when running the flatpak with devel permissions), which caused the apksigner-step to fail with the message:

editor/export/editor_export_platform.h:179 - Code Signing: All 'apksigner' tools located in Android SDK 'build-tools' directory failed to execute. Please check that you have the correct version installed for your target sdk version. The resulting APK is unsigned.

See also godotengine/godot-docs#8742

This patch reverts to the old behaviour of installing the Freedesktop Sdk Extension and updates it from Version 11 to the recommended Version 17

flathubbot commented 9 months ago

Started test build 93407

flathubbot commented 9 months ago

Build 93407 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/76150/org.godotengine.Godot.flatpakref