Closed Zishan-Rahman closed 3 months ago
Build 133627 failed
Started test build 133643
Build 133643 failed
@wjt Sorry for the ping, but it appears that the changes you made for https://github.com/flathub/org.godotengine.Godot/pull/170 are now generating a linter error that is effectively stopping this PR's test build from succeeding: finish-args-contains-both-x11-and-wayland
. I don't know exactly when this was enforced, but I do know that this wasn't an issue when you opened your PR and it got merged.
Usually, the right fix would be to rewrite --socket=x11
in finish-args
as --socket=fallback-x11
, but as you said in your PR, there is a perfectly valid reason why you didn't do that:
Godot 4.3 adds opt-in Wayland support. To use this, the Wayland socket is of course needed.
--socket=x11 is left as-is rather than being replaced with fallback-x11 because X11 remains the default; manual intervention is needed to configure the editor and/or game to use Wayland.
So we need to either (1) take out --socket=wayland
from finish-args
, effectively undoing the changes you made in your PR, or (2) grant this Flatpak an exception to this error so that both of the socket
finish-args
can be kept, which is possible through opening a PR for flatpak-builder-lint, as it already grants this Flatpak an exception for --talk-name=org.freedesktop.Flatpak
.
I'd like your opinion on what to do before I commit to a final decision, so please let me know what you think we should do at your earliest opportunity. I look forward to your advice and suggestions.
I suggest option 2.
I suggest option 2.
@wjt (sorry for the ping) Thanks for your suggestion. I opened a flatpak-builder-lint PR here: https://github.com/flathub-infra/flatpak-builder-lint/pull/433
bot, build
Queued test build for org.godotengine.Godot.
Started test build 134271
Build 134271 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/117281/org.godotengine.Godot.flatpakref
@Calinou looks like this PR can finally be merged now :+1:
Started test build 133627