search

flathub / org.godotengine.Godot

Godot engine
https://flathub.org/apps/details/org.godotengine.Godot
39 stars 25 forks source link

Update Godot to 4.3-beta3 for Flathub Beta #175

Closed Zishan-Rahman closed 3 months ago

flathubbot commented 3 months ago

Started test build 133627

flathubbot commented 3 months ago

Build 133627 failed

flathubbot commented 3 months ago

Started test build 133643

flathubbot commented 3 months ago

Build 133643 failed

Zishan-Rahman commented 3 months ago

@wjt Sorry for the ping, but it appears that the changes you made for https://github.com/flathub/org.godotengine.Godot/pull/170 are now generating a linter error that is effectively stopping this PR's test build from succeeding: finish-args-contains-both-x11-and-wayland. I don't know exactly when this was enforced, but I do know that this wasn't an issue when you opened your PR and it got merged.

Usually, the right fix would be to rewrite --socket=x11 in finish-args as --socket=fallback-x11, but as you said in your PR, there is a perfectly valid reason why you didn't do that:

Godot 4.3 adds opt-in Wayland support. To use this, the Wayland socket is of course needed.

--socket=x11 is left as-is rather than being replaced with fallback-x11 because X11 remains the default; manual intervention is needed to configure the editor and/or game to use Wayland.

So we need to either (1) take out --socket=wayland from finish-args, effectively undoing the changes you made in your PR, or (2) grant this Flatpak an exception to this error so that both of the socket finish-args can be kept, which is possible through opening a PR for flatpak-builder-lint, as it already grants this Flatpak an exception for --talk-name=org.freedesktop.Flatpak.

I'd like your opinion on what to do before I commit to a final decision, so please let me know what you think we should do at your earliest opportunity. I look forward to your advice and suggestions.

wjt commented 3 months ago

I suggest option 2.

Zishan-Rahman commented 3 months ago

I suggest option 2.

@wjt (sorry for the ping) Thanks for your suggestion. I opened a flatpak-builder-lint PR here: https://github.com/flathub-infra/flatpak-builder-lint/pull/433

Zishan-Rahman commented 3 months ago

bot, build

flathubbot commented 3 months ago

Queued test build for org.godotengine.Godot.

flathubbot commented 3 months ago

Started test build 134271

flathubbot commented 3 months ago

Build 134271 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/117281/org.godotengine.Godot.flatpakref
Zishan-Rahman commented 3 months ago

@Calinou looks like this PR can finally be merged now :+1: