search

flathub / org.godotengine.Godot

Godot engine
https://flathub.org/apps/details/org.godotengine.Godot
38 stars 23 forks source link

Support Godot Language Server Protocol TCP Socket #57

Closed hammerandtongs closed 4 years ago

hammerandtongs commented 4 years ago

https://github.com/godotengine/godot/pull/35864

It seems like the existing "--share=network" in the manifest covers this but just opened this to flag it?

Calinou commented 4 years ago

Have you tested it with an editor that only supports communication via TCP sockets? Note that the PR in question was merged after 3.2.1, so you need to use 3.2.2-beta1 or build the 3.2 branch from source.

You can test this by cloning this repository, changing the SHA-256 checksum and tarball URL on these lines to the following:

sha256: fae1b17ca480082c0c1f96ece4297502cb244e3fe62345392264e45f352a14dd
url: https://downloads.tuxfamily.org/godotengine/3.2.2/beta1/godot-3.2.2-beta1.tar.xz

Then build the Flatpak with flatpak-builder:

flatpak-builder --force-clean --user --install builddir org.godotengine.Godot.yaml
hammerandtongs commented 4 years ago

Very happy to test!

On ubuntu 19.10 eoan -

  1. Pulled this repository

  2. Edited org.godotengine.Godot.yaml as suggested

  3. sudo apt install flatpak-builder

  4. git submodule init;git submodule update

  5. flatpak install org.freedesktop.Sdk//19.08

  6. sudo apt install scons

  7. flatpak-builder --force-clean --user --install builddir org.godotengine.Godot.yaml

This fails unfortunately -

Committing stage build-glu to cache

Building module scons in /home/adam/tmp/org.godotengine.Godot/.flatpak-builder/build/scons-1

Running: python3 setup.py install --prefix=/app python3: can't open file 'setup.py': [Errno 2] No such file or directory Error: module scons: Child process exited with code 2

hammerandtongs commented 4 years ago

Was not able to get that laptop building godot via flatpak-builder despite godot being able to build normally.

Moved to a different host and was able to build flatpak AND successfully test the lsp.

It mostly? seems to work for completion and doc on hover, not sure about all the extras but this seems to validate the manifest works well for godot+lsp.

I have some errors in the Messages buffer but I will explore the issue over at the lsp-mode github.

Thanks for the help and the flatpak in general!