flathub / org.godotengine.godot.BaseApp

16 stars 7 forks source link

Support for Godot 4 #39

Closed OverloadedOrama closed 2 weeks ago

OverloadedOrama commented 1 month ago

Is support for Godot 4 planned? Pixelorama v1.0 is about to release very soon, and since it's using Godot 4.2, it is going to need the BaseApp to support Godot 4. Since Godot 4.3 is just around the corner, I wouldn't mind if the BaseApp skipped 4.2 and went straight for 4.3, as I'm also planning to use 4.3 for the next Pixelorama version after v1.0.

Calinou commented 1 month ago

Yes, but I don't have time to work on it personally, so someone else will have to take on this work.

Note that PRs can't create new branches and this repository has protected branch creation, so Flathub admins must create the branch/4.3 branch IIRC.

MateusRodCosta commented 1 month ago

I have some skills in shipping Flatpaks but have yet to ship a Godot game or any other type of project that needs a specific "BaseApp". I would like to help here, what would be need to port to Godot 4.3?

Calinou commented 1 month ago

I would like to help here, what would be need to port to Godot 4.3?

This is mostly about updating the buildsystem in the Flatpak manifest to follow the changes that were made in https://github.com/flathub/org.godotengine.Godot between and 4.x. Compare that repository with https://github.com/flathub/org.godotengine.Godot3 which still builds Godot 3.x for reference.

MateusRodCosta commented 1 month ago

I tried adapting to Godot 4.3-beta3, here are the results: https://github.com/MateusRodCosta/org.godotengine.godot.BaseApp/tree/branch/4.3

It does build successfully but I didn't test it yet though.

MateusRodCosta commented 1 month ago

Godot 4.2 (4.2.2) now supported as https://github.com/MateusRodCosta/org.godotengine.godot.BaseApp/tree/branch/4.2

OverloadedOrama commented 1 month ago

Godot 4.2 (4.2.2) now supported as https://github.com/MateusRodCosta/org.godotengine.godot.BaseApp/tree/branch/4.2

Tested the 4.2 baseapp with Pixelorama 1.0 and it seems to be working well!

OverloadedOrama commented 2 weeks ago

I tried adapting to Godot 4.3-beta3, here are the results: https://github.com/MateusRodCosta/org.godotengine.godot.BaseApp/tree/branch/4.3

We should merge that branch as well now that 4.3 stable is out.

MateusRodCosta commented 2 weeks ago

I tried adapting to Godot 4.3-beta3, here are the results: https://github.com/MateusRodCosta/org.godotengine.godot.BaseApp/tree/branch/4.3

We should merge that branch as well now that 4.3 stable is out.

I deleted that branch and kinda re-did the 4.2 branch based on 3.5-23.08. I will re-do the 4.3 branch soon.

Calinou commented 2 weeks ago

Implemented by: