flathub / org.gtk.Gtk3theme.Yaru-Red-dark

https://flathub.org/apps/details/org.gtk.Gtk3theme.Yaru-Red-dark
GNU General Public License v3.0
0 stars 1 forks source link

Case mismatch? org.gtk.Gtk3theme.Yaru-Red-dark vs Yaru-red-dark #1

Open ernstp opened 2 years ago

ernstp commented 2 years ago

I get legacy integration with Evolution from flathub when I have "Yaru-dark" selected, but not with "Yaru-red-dark". Is it because the flatpak theme is called Yaru-Red-dark with an uppercase R perhaps.. ?

Mek101 commented 2 years ago

That should the cause. I don't know for sure which capitalization is right though. From where did you get get it from?

ernstp commented 2 years ago

In gnome-tweaks you can see that the theme name is "Yaru-red-dark". And this Flatpak stuff is named Yaru-Red-dark.

Mek101 commented 2 years ago

How are the other colors capitalized?

ernstp commented 2 years ago

It's the same pattern with all the other colors!

3v1n0 commented 2 years ago

The problem is not only on naming, but mostly that this repo should now be rebased on upstream Yaru that supports color variants.

Old variants are not supported upstream, where just a fork.

Mek101 commented 2 years ago

The problem is not only on naming, but mostly that this repo should now be rebased on upstream Yaru that supports color variants.

I just package the themes into flatpaks, you should go and ask at https://github.com/Jannomag/Yaru-Colors for an upstream rebase

Old variants are not supported upstream, where just a fork.

I... don't understand this phrase

3v1n0 commented 2 years ago

I just package the themes into flatpaks, you should go and ask at https://github.com/Jannomag/Yaru-Colors for an upstream rebase

Nope, I don't expect that repository to be maintained as it is, now upstream Yaru supports different colors natively so this repo should be changed to track that instead.

Old variants are not supported upstream, where just a fork.

I... don't understand this phrase

Sorry I put an extra h, but I meant that Yaru-Colors is a fork of upstream Yaru, and it's not something that should be used anymore.

3v1n0 commented 2 years ago

So something like this (untested) should be done: https://github.com/3v1n0/org.gtk.Gtk3theme.Yaru-Red-dark/commit/a11a8b9b6f0e27864b84079961f46f137c5308fa

3v1n0 commented 2 years ago

As mentioned by @ernstp it's very likely that the name case mismatch is causing issues though, so in such case we should probably open a new repo for this?

Mek101 commented 2 years ago

The flatpak's name is determinated by the id field, so we should be able to just change the capitalization and it should be fine

Mek101 commented 2 years ago

The yaru colors are bark, sage, olive, viridian, prussiangreen, blue, purple, magenta and red right? https://github.com/ubuntu/yaru/blob/master/common/accent-colors.scss.in

Mek101 commented 2 years ago

The flatpak's name is determinated by the id field, so we should be able to just change the capitalization and it should be fine

Although this would break compatibility with Focal Fossa users still using Yaru-Colors

santiagofn commented 2 years ago

I've tried other colors (like Yaru-olive-dark) and the same thing happens there: differente case and lack of support for accent colors. Seems like https://github.com/flathub/org.gtk.Gtk3theme.Yaru-Red-dark/issues/1#issuecomment-1089184601 should be applied to all the variants.

joenepraat commented 2 years ago

Any update? Purple Dark is my favorite theme, but some apps are displayed as the light default. The Prussian Green Dark is (for example) displayed like it should on these apps.

amardhruva commented 1 year ago

Purple Light User here. I would love to get my flatpak apps themed. Btw is there something blocking from creating two repos one with legacy support and one with lowercase new themes?