flathub / org.kde.digikam

https://flathub.org/apps/details/org.kde.digikam
5 stars 10 forks source link

Do not delete libtool files of ImageMagick coders #43

Closed pkrause1980 closed 2 years ago

pkrause1980 commented 2 years ago

Fixes #42.

The cause is the ImageMagick module itself being broken, tested by removing "/bin" from the cleanup phase and, e.g., "display -list format". That is fixed by removing "*la" from the cleanup and Digikam works as expected afterwards.

The cleanup of ".la" had to be moved to the individual modules. I do not build the other modules, only boost, opencv, libheif, libde265 and glu, and these do not produce any la files. If they are supposed to have the .la cleanup, I do not see a problem there. If the possible unnecessary cleanup of the other modules are a concern, a buildlog or a build without the cleanup would help.

Alternatively a cleanup command like "find /app/lib/ -type f -name '*.la' -not -ipath '*ImageMagick*coders*' -delete" would do the work.

flathubbot commented 2 years ago

Started test build 108958

flathubbot commented 2 years ago

Build 108958 failed

flathubbot commented 2 years ago

Started test build 108964

flathubbot commented 2 years ago

Build 108964 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/106609/org.kde.digikam.flatpakref
pkrause1980 commented 2 years ago

Build 108964 works as expected (installed and tested). Commit c980baa should too (tested locally with own build).

flathubbot commented 2 years ago

Started test build 109386

flathubbot commented 2 years ago

Build 109386 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/107024/org.kde.digikam.flatpakref
ElXreno commented 2 years ago

I apologize for the delay. LGTM.