flathub / org.kde.digikam

https://flathub.org/apps/details/org.kde.digikam
5 stars 10 forks source link

KDE KF6 update #77

Closed travier closed 7 months ago

flathubbot commented 8 months ago

Started test build 106541

flathubbot commented 8 months ago

Build 106541 failed

travier commented 8 months ago

https://invent.kde.org/education/marble/-/issues/12

Erick555 commented 8 months ago

Is it an option to temporarily drop geolocation support?

travier commented 8 months ago

I'd say that would be up to the maintainer, but we are not yet in a hurry so we can wait a bit for the marble port to get merged.

cgilles commented 8 months ago

You have an option in digiKam cmake rules to disable Geolocation.

You don't need to wait for Marble, digiKam include a simplified port to Qt6 of Marble (as i never receive a response of Marble team about this topic since a very long time, so i do it).

travier commented 7 months ago

You don't need to wait for Marble, digiKam include a simplified port to Qt6 of Marble (as i never receive a response of Marble team about this topic since a very long time, so i do it).

Does this mean that we can completely drop the dependency on Marble?

flathubbot commented 7 months ago

Started test build 113574

flathubbot commented 7 months ago

Build 113574 failed

Erick555 commented 7 months ago

For some reason digikam removed old tarball. News one is at https://download.kde.org/stable/digikam/8.3.0/digiKam-8.3.0-1.tar.xz

flathubbot commented 7 months ago

Started test build 113607

hfiguiere commented 7 months ago

For some reason digikam removed old tarball. News one is at https://download.kde.org/stable/digikam/8.3.0/digiKam-8.3.0-1.tar.xz

See also https://github.com/flathub/org.kde.digikam/pull/78#issuecomment-2046838848

flathubbot commented 7 months ago

Build 113607 failed

flathubbot commented 7 months ago

Started test build 113721

flathubbot commented 7 months ago

Build 113721 failed

flathubbot commented 7 months ago

Started test build 113747

flathubbot commented 7 months ago

Build 113747 failed

Erick555 commented 7 months ago

I think you need to pass -DBUILD_WITH_QT6=ON for digikam (off by default)

Also remove "cxxflags": "-isystem /app/include/KF5"

flathubbot commented 7 months ago

Started test build 114215

flathubbot commented 7 months ago

Build 114215 failed

Erick555 commented 7 months ago

for mosaicwall you need to use commit from of git branch since there is no qt6 compatible release yet

flathubbot commented 7 months ago

Started test build 114338

flathubbot commented 7 months ago

Build 114338 was cancelled

flathubbot commented 7 months ago

Started test build 114339

flathubbot commented 7 months ago

Build 114339 failed

flathubbot commented 7 months ago

Started test build 114356

flathubbot commented 7 months ago

Build 114356 failed

flathubbot commented 7 months ago

Started test build 114365

flathubbot commented 7 months ago

Started test build 114366

travier commented 7 months ago

Too many changes in this PR so splitting the common updates in https://github.com/flathub/org.kde.digikam/pull/80

flathubbot commented 7 months ago

Build 114366 was cancelled

flathubbot commented 7 months ago

Build 114365 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/97177/org.kde.digikam.flatpakref
Erick555 commented 7 months ago

Too many changes in this PR so splitting the common updates in #80

Since that doesn't work yet and this one does maybe merge this one and be done with digikam for a while.

flathubbot commented 7 months ago

Started test build 114711

travier commented 7 months ago

There is a ton of work to do on this Flatpak:

Thus a lot of dependencies are really outdated.

flathubbot commented 7 months ago

Build 114711 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/97525/org.kde.digikam.flatpakref
Erick555 commented 7 months ago

Most dependencies are using Git repos instead of tarballs

are you suggesting this is wrong thing, especially after recent events?

cgilles commented 7 months ago

You don't need to wait for Marble, digiKam include a simplified port to Qt6 of Marble (as i never receive a response of Marble team about this topic since a very long time, so i do it).

Does this mean that we can completely drop the dependency on Marble?

yes it is...

cgilles commented 7 months ago

for mosaicwall you need to use commit from of git branch since there is no qt6 compatible release yet

yes mosaicwall 3rdparty plugin is not yet ported to new Exiv2/Qt6 API i open a MR i this way but it's not yet integrated.

Anyway, you can always take a look to my CD script for AppImage, Windows and MacOS which integrate the last rules to be update.

Windows bundle is Qt6 based now. So mosaiwall plugin is patched like this :

https://invent.kde.org/graphics/digikam/-/tree/master/project/bundles/3rdparty/ext_mosaicwall?ref_type=heads

Gilles

travier commented 7 months ago

are you suggesting this is wrong thing, especially after recent events?

Yes, it's about cost saving for the Flathub infra. We're not going to stop using tarballs because one project's tarballs were compromised.

Erick555 commented 7 months ago

f-b does shallow clones so I'm not sure where are the cost savings. git has transparency that tarballs lack.

travier commented 7 months ago

Yes, this is better than full a clone but still significantly slower and less CPU efficient than downloading a tarball.

Anyway, this is a general KDE Apps on Flathub "policy" and orthogonal to this issue.

Erick555 commented 7 months ago

Ok, is there anything left do to for this PR?

travier commented 7 months ago

The application appears to be working, but it requires full home access to be useful :/. We're in the same boat as Elisa for example.

https://github.com/flathub/org.kde.digikam/pull/67

https://github.com/flathub/org.kde.digikam/issues/3

flathubbot commented 7 months ago

Started test build 115227

flathubbot commented 7 months ago

Build 115227 failed

travier commented 7 months ago

The diff with the previous push is in https://github.com/flathub/org.kde.digikam/compare/30bfd155375b831509e0913f64e2502329008fc0..fea613195c6b5cd43687dc4a9951f153e3178d76 and I did not touch hugin, which is failing now :/

Erick555 commented 7 months ago

The error is:

/run/build/hugin/src/tools/pto_move.cpp: In function ‘bool PTOCopyMove(bool, boost::filesystem::path, boost::filesystem::path, bool)’: /run/build/hugin/src/hugin_base/hugin_utils/filesystem.h:67:51: error: ‘boost::filesystem::copy_option’ has not been declared 67 | #define OVERWRITE_EXISTING boost::filesystem::copy_option::overwrite_if_exists

Last working build had boost 1.84 (boost_1_84_0.tar.bz2)

Broken build has boost 1.85 (boost_1_85_0.tar.bz2)

Erick555 commented 7 months ago

You can even spot boost was broken in https://github.com/flathub/org.kde.digikam/pull/81

flathubbot commented 7 months ago

Started test build 115320