Closed travier closed 7 months ago
Build 106541 failed
Is it an option to temporarily drop geolocation support?
I'd say that would be up to the maintainer, but we are not yet in a hurry so we can wait a bit for the marble port to get merged.
You have an option in digiKam cmake rules to disable Geolocation.
You don't need to wait for Marble, digiKam include a simplified port to Qt6 of Marble (as i never receive a response of Marble team about this topic since a very long time, so i do it).
You don't need to wait for Marble, digiKam include a simplified port to Qt6 of Marble (as i never receive a response of Marble team about this topic since a very long time, so i do it).
Does this mean that we can completely drop the dependency on Marble?
Started test build 113574
Build 113574 failed
For some reason digikam removed old tarball. News one is at https://download.kde.org/stable/digikam/8.3.0/digiKam-8.3.0-1.tar.xz
Started test build 113607
For some reason digikam removed old tarball. News one is at https://download.kde.org/stable/digikam/8.3.0/digiKam-8.3.0-1.tar.xz
See also https://github.com/flathub/org.kde.digikam/pull/78#issuecomment-2046838848
Build 113607 failed
Started test build 113721
Build 113721 failed
Started test build 113747
Build 113747 failed
I think you need to pass -DBUILD_WITH_QT6=ON
for digikam (off by default)
Also remove "cxxflags": "-isystem /app/include/KF5"
Started test build 114215
Build 114215 failed
for mosaicwall you need to use commit from of git branch since there is no qt6 compatible release yet
Started test build 114338
Build 114338 was cancelled
Started test build 114339
Build 114339 failed
Started test build 114356
Build 114356 failed
Started test build 114365
Started test build 114366
Too many changes in this PR so splitting the common updates in https://github.com/flathub/org.kde.digikam/pull/80
Build 114366 was cancelled
Build 114365 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/97177/org.kde.digikam.flatpakref
Too many changes in this PR so splitting the common updates in #80
Since that doesn't work yet and this one does maybe merge this one and be done with digikam for a while.
Started test build 114711
There is a ton of work to do on this Flatpak:
Thus a lot of dependencies are really outdated.
Build 114711 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/97525/org.kde.digikam.flatpakref
Most dependencies are using Git repos instead of tarballs
are you suggesting this is wrong thing, especially after recent events?
You don't need to wait for Marble, digiKam include a simplified port to Qt6 of Marble (as i never receive a response of Marble team about this topic since a very long time, so i do it).
Does this mean that we can completely drop the dependency on Marble?
yes it is...
for mosaicwall you need to use commit from of git branch since there is no qt6 compatible release yet
yes mosaicwall 3rdparty plugin is not yet ported to new Exiv2/Qt6 API i open a MR i this way but it's not yet integrated.
Anyway, you can always take a look to my CD script for AppImage, Windows and MacOS which integrate the last rules to be update.
Windows bundle is Qt6 based now. So mosaiwall plugin is patched like this :
Gilles
are you suggesting this is wrong thing, especially after recent events?
Yes, it's about cost saving for the Flathub infra. We're not going to stop using tarballs because one project's tarballs were compromised.
f-b does shallow clones so I'm not sure where are the cost savings. git has transparency that tarballs lack.
Yes, this is better than full a clone but still significantly slower and less CPU efficient than downloading a tarball.
Anyway, this is a general KDE Apps on Flathub "policy" and orthogonal to this issue.
Ok, is there anything left do to for this PR?
The application appears to be working, but it requires full home access to be useful :/. We're in the same boat as Elisa for example.
Started test build 115227
Build 115227 failed
The diff with the previous push is in https://github.com/flathub/org.kde.digikam/compare/30bfd155375b831509e0913f64e2502329008fc0..fea613195c6b5cd43687dc4a9951f153e3178d76 and I did not touch hugin, which is failing now :/
The error is:
/run/build/hugin/src/tools/pto_move.cpp: In function ‘bool PTOCopyMove(bool, boost::filesystem::path, boost::filesystem::path, bool)’: /run/build/hugin/src/hugin_base/hugin_utils/filesystem.h:67:51: error: ‘boost::filesystem::copy_option’ has not been declared 67 | #define OVERWRITE_EXISTING boost::filesystem::copy_option::overwrite_if_exists
Last working build had boost 1.84 (boost_1_84_0.tar.bz2)
Broken build has boost 1.85 (boost_1_85_0.tar.bz2)
You can even spot boost was broken in https://github.com/flathub/org.kde.digikam/pull/81
Started test build 115320
Started test build 106541