search

flathub / org.kde.digikam

https://flathub.org/apps/details/org.kde.digikam
5 stars 10 forks source link

Reconsider static filesystem permissions #85

Open travier opened 5 months ago

travier commented 5 months ago

Ideally, Digikam would ask the user to grant it static access to specific folders via the Flatpak settings page or Flatseal.

Until that happens, we enabled static access to the entire home folder to make the application usable by default for most common use cases.

See:

Erick555 commented 5 months ago

For flatpak ideal is using xdg-portal for opening files/folders rather than asking for permissions.

travier commented 5 months ago
travier commented 5 months ago

So it's more about making sure the application correctly uses the answer from the portal and we don't need to have people edit permissions in the settings / using Flatseal.

Erick555 commented 5 months ago

The thing is digikam disables by default using system file dialogs which break the file portals.

If you go to the: Settings -> Configure digikam -> Miscellaneous -> Appearance and check Use native file dialogs from system or flip Use Native File Dialog=false to true in ~/.var/app/org.kde.digikam/config/digikamrc then file portal support work without any further changes.

I don't know what are the reasons behind this and if those reasons are worth seriously decreasing security of flatpak sandbox.

Erick555 commented 5 months ago

Heh, apparently system file dialogs are disabled because something was crashing on ubuntu long time ago. The fix is rather far from ideal and cripples flatpak.

You may consider patching this behavior instead of disabling sandbox cc @Pointedstick

Erick555 commented 5 months ago

@cgilles can digikam reconsider enabling native file dialogs?