search

flathub / org.kde.gwenview

https://flathub.org/apps/details/org.kde.gwenview
1 stars 4 forks source link

Specify custom buildirectory for jasper #116

Closed bbhtt closed 9 months ago

bbhtt commented 10 months ago

A test...

flathubbot commented 10 months ago

Started test build 86770

flathubbot commented 10 months ago

Build 86770 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/69427/org.kde.gwenview.flatpakref
tsdgeos commented 10 months ago

We went with https://github.com/flathub/org.kde.gwenview/pull/114/files

That also works, right?

bbhtt commented 10 months ago

We went with https://github.com/flathub/org.kde.gwenview/pull/114/files

That also works, right?

I think so, but I'm not familiar with jasper or why it doesn't like building in a subdir of source/implications of not doing it/disabling it.

This works but looks a bit ugly. I was just checking if it worked.

Justinzobel commented 9 months ago

Does this need further work or did 114 fix the build directory?

bbhtt commented 9 months ago

It disabled the check for in source build. https://github.com/flathub/org.kde.gwenview/blob/9246312fa16f4acecaced1877eb7bfa7e152c3b9/org.kde.gwenview.json#L132

Anyway, this shouldn't be needed right now