search

flathub / org.kde.gwenview

https://flathub.org/apps/details/org.kde.gwenview
1 stars 3 forks source link

Update 2 modules #122

Closed flathubbot closed 6 months ago

flathubbot commented 6 months ago

Update v0.2.0.tar.gz to 0.3.0 Update v0.6.1.tar.gz to 0.7.0

🤖 This pull request was automatically generated by flathub-infra/flatpak-external-data-checker. Please open an issue if you have any questions or complaints. 🤖

flathubbot commented 6 months ago

Started test build 94135

flathubbot commented 6 months ago

Build 94135 failed

travier commented 6 months ago 
-- The following OPTIONAL packages have not been found:
 * tiff
-- The following REQUIRED packages have not been found:
 * kImageAnnotator, The kImageAnnotator library provides tools to annotate, <https://github.com/ksnip/kImageAnnotator>
travier commented 6 months ago

This is weird given that the package is built right before

Erick555 commented 6 months ago

@travier this looks related https://github.com/ksnip/kImageAnnotator/pull/329

DamirPorobic commented 6 months ago

I think you need to change how to link to kImageAnnotator if you haven't done that yet. Here is an example in kColorPicker which should be using the same linking https://github.com/ksnip/kColorPicker?tab=readme-ov-file#integrate-library-in-project

Erick555 commented 6 months ago

I see qt5 support is going to be dropped completely in next release instead which means everyone who wants to keep using qt5 needs to patch gwenveiw or kImageAnnotator themselves which is quite unpleasant.

Keeping old headers untoched which was alternatively proposed in kImageAnnotator PR would make smooth transition without downstream hacks like this.

travier commented 6 months ago

Thanks @Erick555 for the tips! (here and in other repos)

Closing in favor of https://github.com/flathub/org.kde.gwenview/pull/123 where I pushed the "fix".