search

flathub / org.kde.gwenview

https://flathub.org/apps/details/org.kde.gwenview
1 stars 4 forks source link

Add kf5arcive, libavif, libheif, libjxl, and openexr for KImageFormats #30

Open alastortenebris opened 2 years ago

alastortenebris commented 2 years ago

KImageFormats adds support for multiple image formats such as psd, jxl, and avif.

travier commented 2 years ago

https://invent.kde.org/packaging/flatpak-kde-runtime/-/merge_requests/90

vulongm commented 2 years ago

Looks like kf5arcive, libavif, libheif, libjxl, and openexr might have to be added to the manifest for the package or runtime as well for some of the additional formats to work with KimageFormats. https://invent.kde.org/frameworks/kimageformats/-/blob/master/CMakeLists.txt

travier commented 2 years ago

They need to be added to the runtime too

vulongm commented 2 years ago

For some dependencies like libavif that might be a bit trickier as it requires rav1e and cargo-c which uses Rust SDK. Krita uploaded tarballs for those dependencies at https://files.kde.org/krita/build/dependencies/flatpak/ which allows for offline installation that can be used with flatpak-builder.

See https://github.com/flathub/org.kde.krita/blob/89ab5bdf5a581bd4709f63fec92e6b1fad551b0b/org.kde.krita.yaml#L721 for reference as well on the manifest.

travier commented 2 years ago

There is a script to generate manifest from Rust dependencies somewhere on Flathub so that you don't have to do as Krita does AFAIK.

travier commented 2 years ago

Clearing the assignee as I'm not actively working on this.

travier commented 2 years ago

jxl & libavif: https://invent.kde.org/packaging/flatpak-kde-runtime/-/commit/60ae78cb9556afa0d9cdea56200008c4d3f6ef7b

Justinzobel commented 1 year ago

MR for adding libheif here https://invent.kde.org/packaging/flatpak-kde-runtime/-/merge_requests/158