Build sasl with liblogin

[detrout]

Update to use the same settings as the Freedesktop build scripts. (Other than the path to libdb, which should just use the version provided by the Freedesktop platform instead of whatever "STAGING_DIR" was set to.)

Once plasma booted correctly, I was able to send email via office365 using

flatpak-builder --run build-dir org.kde.kontact.json run_kontact.sh

[danvratil]

Looks good, but could you please fix the indentation? You can just pipe the file through json_verify, that should be enough.

[detrout]

Hmm... I think I fixed it, but then I did a force push, so there's only one correct commit.

But that seems to have confused github. Should I kill this pull request and try again? or is there some other way around it?

(I use emacs, so to fix it I told it not to insert tabs for javascript and ran whitespace-cleanup. As far as I can tell there's no tabs now)

[detrout]

So my build now fails.... and I'm not really sure how to debug this.

flatpak-builder --run build-dir org.kde.kontact.json run_kontact.sh
Akonadi is not running.
kbuildsycoca5 running...
Connecting to deprecated signal QDBusConnectionInterface::serviceOwnerChanged(QString,QString,QString)
QSqlDatabasePrivate::addDatabase: duplicate connection name 'initConnection', old connection removed.
Connecting to deprecated signal QDBusConnectionInterface::serviceOwnerChanged(QString,QString,QString)
The X11 connection broke: Maximum allowed requested length exceeded (code 4)
XIO:  fatal IO error 2 (No such file or directory) on X server ":99.0"
      after 494 requests (494 known processed) with 0 events remaining.
Akonadi is not running.

(process:20503): flatpak-WARNING **: 13:01:52.352: Error writing credentials to socket: Error sending message: Broken pipe
trying to load "/usr/lib/plugins/kf5/kio/http.so" from "/usr/lib/plugins/kf5/kio/http.so"
trying to load "/usr/lib/plugins/kf5/kio/http.so" from "/usr/lib/plugins/kf5/kio/http.so"
kf5.kio.core: Can't communicate with kiod_kpasswdserver (for checkAuthInfo)!
kf5.kio.core: Can't communicate with kiod_kpasswdserver (for checkAuthInfo)!
kf5.kio.core: Can't communicate with kiod_kpasswdserver (for checkAuthInfo)!
kf5.kio.core: Can't communicate with kiod_kpasswdserver (for checkAuthInfo)!
kf5.kio.core: Can't communicate with kiod_kpasswdserver (for checkAuthInfo)!
kf5.kio.core: Can't communicate with kiod_kpasswdserver (for checkAuthInfo)!

[danvratil]

bot, build org.kde.kontact

[detrout]

Well that's a convenient bot.

[danvratil]

Looks like the build fails https://flathub.org/builds/#/builders/2/builds/5178 :( can you look into it?

Unfortunately the bot does not produce downloadable builds for testing :(

[detrout]

ln: failed to create symbolic link 'plugin_common.o': File exists```

I found the failed to create symbolic link plugin error in the x86_64 and arm logs.

Cyrus's build scripts didn't recognize the aarch platform.

Do you know if the builder is running parallel make? (And is this a setting that can be turned on, but defaults to off? and so might be different from my local build?)

[danvratil]

Yes, it is running parallel builds by default. You can add no-parallel-make: true to the module to prevent that.

Regarding the aarch platform, that's usually because the autoconfig script is too old and does not even know about aarch64. The recipe from feedesktop-sdk-base contains this bit:

do_configure_prepend () {
    rm -f ${S}/acinclude.m4 ${S}/config/libtool.m4
}

I suppose removing the autoconfig scripts from the sources makes the autoconf to fallback to some system-wide scripts, which should be new enough to be aware of aarch64.

[detrout]

bot, build org.kde.kontact

[detrout]

Will it let me do that?

I managed to insert the changes to remove upstreams libtool aclocal files. I left off the non-parallel fix on the hope that it'll work correctly with newer auto tool files.

Also sadly flatpak-builder run didn't work for me which made testing a bit more inconvenient. (I was getting X errors)

[danvratil]

bot, build org.kde.kontact

[danvratil]

Sadly, the bot only obeys the repo owners (bad bot!)

I need to start updating to 18.08.2 slowly, I'll take a look at this if the build fails.

[danvratil]

Hmm didn't work :( https://flathub.org/builds/#/builders/2/builds/5362

[danvratil]

bot, build org.kde.kontact

[danvratil]

I dared to push a change to your branch, which appears to have worked - sorry for misguiding you regarding the m4 files, turned out it was config.guess and config.sub that needed to be replaced with newer ones.

I'm running a build locally now to verify that Kontact can find the LOGIN plugin correctly, and will merge this if everything is OK.

[detrout]

What's the difference between script and shell?

Also should bugs that I observe that seem to be more about kmail than the flatpak packaging go here or to the kontact phabricator, or to bugs.kde.org?

(Examples sometimes I get 100% CPU usage in an akonadi imap process)

Sometimes kmail blocks with a grayed out UI when trying to move delete mail. I see kf5.kio.core: Can't communicate with kiod_kpasswdserver (for checkAuthInfo)! in the stdout logs.

[danvratil]

script is turned into a shell file that is placed into the source dir (when you specify destination-path, shell are commands actually executed after extracting the source tarballs.

If you think something is a bug in KMail/Kontact/Akonadi/... report it to bugs.kde.org please - we can triage it there.