search

flathub / org.kde.krdc

https://flathub.org/apps/details/org.kde.krdc
0 stars 3 forks source link

Could not start "wlfreerdp" error, since recent update #49

Closed DamienGombaultRecia closed 11 months ago

DamienGombaultRecia commented 11 months ago

I have recently updated KRDC to version 23.08.4 from Flathub. I cannot connect to RDP anymore, I got this error : Could not start "wlfreerdp"; make sure wlfreerdp is properly installed.

I use Fedora Kinoite 39 with Wayland.

DamienGombaultRecia commented 11 months ago

I have downgraded to commit 3fe153eb4bdec2620b6d482b2fb7af579c135e02a55780cc7b0f89d824480ab2 No problem with this version, RDP connection works as expected.

KRDC - Se connecter à un autre ordinateur avec RDP ou VNC

        ID: org.kde.krdc
       Ref: app/org.kde.krdc/x86_64/stable
      Arch: x86_64
    Branch: stable
   Version: 23.08.4
   License: GPL-2.0+
Collection: org.flathub.Stable
  Download: 7,7 Mo
 Installed: 19,1 Mo
   Runtime: org.kde.Platform/x86_64/5.15-23.08
       Sdk: org.kde.Sdk/x86_64/5.15-23.08

    Commit: 315bee75b6333ce2fd6274d2147e4d144d76742d1e260e2d2f7eb705b2f96871
    Parent: 3fe153eb4bdec2620b6d482b2fb7af579c135e02a55780cc7b0f89d824480ab2
   Subject: Add FreeRDP dependencies (9c2ba373)
      Date: 2023-12-18 00:28:54 +0000
   History: 

    Commit: 3fe153eb4bdec2620b6d482b2fb7af579c135e02a55780cc7b0f89d824480ab2
   Subject: Update krdc-23.08.3.tar.xz to 23.08.4 (95f3ee48)
      Date: 2023-12-08 00:11:53 +0000
tsdgeos commented 11 months ago

But 315bee75b6333ce2fd6274d2147e4d144d76742d1e260e2d2f7eb705b2f96871 is the last version.

Which version did you have that didn't work?

DamienGombaultRecia commented 11 months ago

Current working version (3fe153eb4bdec2620b6d482b2fb7af579c135e02a55780cc7b0f89d824480ab2) :

$ flatpak info org.kde.krdc

KRDC - Se connecter à un autre ordinateur avec RDP ou VNC

          ID: org.kde.krdc
         Ref: app/org.kde.krdc/x86_64/stable
        Arch: x86_64
      Branch: stable
     Version: 23.08.4
     License: GPL-2.0+
      Origin: flathub
  Collection: org.flathub.Stable
Installation: system
   Installed: 8,4 Mo
     Runtime: org.kde.Platform/x86_64/5.15-23.08
         Sdk: org.kde.Sdk/x86_64/5.15-23.08

      Commit: 3fe153eb4bdec2620b6d482b2fb7af579c135e02a55780cc7b0f89d824480ab2
      Parent: a766336e75c8650607d45fe3ed35ff9f8d48f2850fdbb447b39381fd72625751
     Subject: Update krdc-23.08.3.tar.xz to 23.08.4 (95f3ee48)
        Date: 2023-12-08 00:11:53 +0000

Flatpak proposes me an updated version from Flathub :

$ flatpak update
Looking for updates…

        ID                   Branch         Op        Remote         Download
 1.     org.kde.krdc         stable         u         flathub        < 7,7 Mo

Proceed with these changes to the system installation? [Y/n]:

Updating to the latest version.

Broken version (Could not start wlfreerdp) (315bee75b6333ce2fd6274d2147e4d144d76742d1e260e2d2f7eb705b2f96871):

$ flatpak info org.kde.krdc

KRDC - Se connecter à un autre ordinateur avec RDP ou VNC

          ID: org.kde.krdc
         Ref: app/org.kde.krdc/x86_64/stable
        Arch: x86_64
      Branch: stable
     Version: 23.08.4
     License: GPL-2.0+
      Origin: flathub
  Collection: org.flathub.Stable
Installation: system
   Installed: 19,1 Mo
     Runtime: org.kde.Platform/x86_64/5.15-23.08
         Sdk: org.kde.Sdk/x86_64/5.15-23.08

      Commit: 315bee75b6333ce2fd6274d2147e4d144d76742d1e260e2d2f7eb705b2f96871
      Parent: 3fe153eb4bdec2620b6d482b2fb7af579c135e02a55780cc7b0f89d824480ab2
     Subject: Add FreeRDP dependencies (9c2ba373)
        Date: 2023-12-18 00:28:54 +0000

No new updates :

$ flatpak update
Looking for updates…

Nothing to do
DamienGombaultRecia commented 11 months ago

wlfreerdp binary is present in commit 3fe153eb4bdec2620b6d482b2fb7af579c135e02a55780cc7b0f89d824480ab2 :

:/var/lib/flatpak/app/org.kde.krdc/x86_64/stable/3fe153eb4bdec2620b6d482b2fb7af579c135e02a55780cc7b0f89d824480ab2/files/bin$ ls -l
total 1068
-rwxr-xr-x. 2 root root 285000  1 janv.  1970 krdc
-rwxr-xr-x. 2 root root  14520  1 janv.  1970 winpr-hash
-rwxr-xr-x. 2 root root  14528  1 janv.  1970 winpr-makecert
-rwxr-xr-x. 2 root root  47368  1 janv.  1970 wlfreerdp
-rwxr-xr-x. 2 root root 723720  1 janv.  1970 xfreerdp

wlfreerdp is missing in commit 315bee75b6333ce2fd6274d2147e4d144d76742d1e260e2d2f7eb705b2f96871 :

/var/lib/flatpak/app/org.kde.krdc/x86_64/stable/315bee75b6333ce2fd6274d2147e4d144d76742d1e260e2d2f7eb705b2f96871/files/bin$ ls -l
total 2108
-rwxr-xr-x. 3 root root    818  1 janv.  1970 compile_et
-rwxr-xr-x. 2 root root  39184  1 janv.  1970 fusermount3
-rwxr-xr-x. 2 root root  26888  1 janv.  1970 gss-client
-rwxr-xr-x. 4 root root   2004  1 janv.  1970 k5srvutil
-rwxr-xr-x. 2 root root  96592  1 janv.  1970 kadmin
-rwxr-xr-x. 2 root root  14520  1 janv.  1970 kdestroy
-rwxr-xr-x. 2 root root  35000  1 janv.  1970 kinit
-rwxr-xr-x. 2 root root  30896  1 janv.  1970 klist
-rwxr-xr-x. 2 root root  14520  1 janv.  1970 kpasswd
-rwxr-xr-x. 2 root root   6760  1 janv.  1970 krb5-config
-rwxr-xr-x. 2 root root 285000  1 janv.  1970 krdc
-rwxr-xr-x. 2 root root  14520  1 janv.  1970 kswitch
-rwxr-xr-x. 2 root root  39184  1 janv.  1970 ktutil
-rwxr-xr-x. 2 root root  22704  1 janv.  1970 kvno
-rwxr-xr-x. 2 root root  14520  1 janv.  1970 sclient
-rwxr-xr-x. 2 root root 674152  1 janv.  1970 sdl-freerdp
-rwxr-xr-x. 2 root root  14520  1 janv.  1970 sim_client
-rwxr-xr-x. 2 root root  18616  1 janv.  1970 uuclient
-rwxr-xr-x. 2 root root  14520  1 janv.  1970 winpr-hash
-rwxr-xr-x. 2 root root  14528  1 janv.  1970 winpr-makecert
-rwxr-xr-x. 2 root root 740104  1 janv.  1970 xfreerdp
tsdgeos commented 11 months ago

Ok, i misunderstood your previous message.

Justinzobel commented 11 months ago

Apologies. Can you test this once the build finishes. I can confirm wlfreerdp is in the bin directory. https://github.com/flathub/org.kde.krdc/pull/50

DamienGombaultRecia commented 11 months ago

Thank you for the new build!

Bad news : the wlfreerdp 3.0 binary is here but it does not work. The CLI options have changed with the 3.0 version.

With debug enabled for KRDC, the RDP connection is not established and fails with the error : [09:24:52:488] [15:0000000f] [ERROR][com.winpr.commandline] - [log_error]: Failed at index 12 [/cert-ignore]: Unexpected keyword

The /cert-ignore option was deprecated and is removed in version 3.0.0.

This is FreeRDP version 2.11.2 (2.11.2)

📦 org.kde.krdc ~]$ wlfreerdp --help | grep cert
    /cert:[deny,ignore,name:<name>,tofu,fingerprint:<hash>:<hash as hex>
                                      connection if the certificate does not
                                      ignore       ... Ignore the certificate
                                      instead of the certificate subject to
                                      match locally stored certificates * tofu  
                                            ... Accept certificate
                                      certificate does not match * fingerprints
                                      ... A list of certificate hashes that are
    /cert-deny                        [deprecated, use /cert:deny] Automatically
                                      abort connection for any certificate that
    /cert-ignore                      [deprecated, use /cert:ignore] Ignore
                                      certificate
    /cert-name:<name>                 [deprecated, use /cert:name:<name>]
    /cert-tofu                        [deprecated, use /cert:tofu] Automatically
                                      accept certificate on first connect

This is FreeRDP version 3.0.0 (n/a)

📦 org.kde.krdc ~]$ wlfreerdp --help | grep cert
    /cert:[deny,ignore,name:<name>,tofu,fingerprint:<hash>:<hash as hex>[
                                      connection if the certificate does not
                                      ignore       ... Ignore the certificate
                                      instead of the certificate subject to
                                      match locally stored certificates * tofu  
                                            ... Accept certificate
                                      certificate does not match * fingerprints
                                      ... A list of certificate hashes that are
                                      certificate/credential/...
    /smartcard-logon[:[cert:<path>,key:<key>,pin:<pin>,csp:<csp name>
                                      Activates Smartcard (optional certificate)

This option is used (hard-coded) in KRDC 23.08.4 here : https://github.com/KDE/krdc/blob/v23.08.4/rdp/rdpview.cpp#L333

I think we cannot use FreeRDP 3.0 with KRDC 23.08.4.

The KRDC RDP plugin was reworked in master : https://github.com/KDE/krdc/commit/3ad8c3dfde8503bea748d4e26610d44ea5805b82 FreeRDP 2.10 is listed as dependencies : https://github.com/KDE/krdc/blob/master/CMakeLists.txt#L129

Justinzobel commented 11 months ago

Thanks for the thorough investigation work @DamienGombaultRecia. I'll roll back the update.

Justinzobel commented 11 months ago

Resolved by #51

travier commented 8 months ago

Hey folks. We are trying to update FreeRDP again in https://github.com/flathub/org.kde.krdc/pull/54. Please give it a try. Thanks

DamienGombaultRecia commented 8 months ago

Hi. I can test the new builds. Is there any new build available ?

travier commented 8 months ago

Could you try https://github.com/flathub/org.kde.krdc/pull/60 ? It's a general update without the FreeRDP update. We'll try to find out about the FreeRDP bump in another PR.