search

flathub / org.kde.okular

https://flathub.org/apps/details/org.kde.okular
6 stars 12 forks source link

Embedding Fira Sans font unnecessarily in the pdf file after editing Inline Note and thus drastically increasing pdf file size. #211

Open root-reborn opened 2 years ago

root-reborn commented 2 years ago

This is another issue that is associated with issue #210 Steps to reproduce: 1)Open any pdf file in okular and in Full Annotation Toolbar change the default font for Inline Note from Fira Sans to any other font(say "Liberation Serif"). 2)Now write some text in the pdf file using Inline Note and save it and close the pdf file. 3)Now open the same pdf file in okular and try to edit the text in the Inline Note you did previously in the pdf file then the font of Inline Note is automatically changing to Fira Sans and this is already addressed in issue #210. 4)So now you have to change the font manually from "Fira Sans" to "Liberation Serif" everytime you edit a Inline Note in the pdf file as a work around to the above bug.Now if I change the font back to "Liberation Serif" via properties menu after editing the Inline Note it is working and Liberation Serif font is seen after saving and opening the pdf file.But the problem is that okular is still fully embedding the "Fira Sans" font inside the pdf file though "Fira Sans" font is not used in the pdf file and thus increasing pdf size very drastically like a bloatware. So there is also issue with the font embedding in okular and the default font(Fira Sans) is always embedded in the pdf file after editing a Inline Note in the pdf file. Example: After using Inline Note tool for first time in a pdf file with "Liberation Serif" font and saving it then pdf file size is increased from 500KB to 1.3MB (ofcourse to fully embed the liberation serif font in the pdf file) and after if I edit that same Inline Note in that pdf file and change the font to "Liberation Serif" (due to issue #210) but still it is increasing the size of pdf file from 1.3MB to 2MB because okular is unnecessarity embedding Fira Sans font in the pdf file and thus making the size of pdf file too large to believe. (Go to File>Properties>Fonts to see the fonts that are embedded in the pdf file.)

Expected behaviour: 1)In the above 4th step after editing Inline Note and after changing the font of Inline Note from Fira Sans to Liberation Serif to bypass issue #210 okular should not embedd the Fira Sans font in the pdf file.

Version:22.08.2 and also 22.08.1 (okular flatpak) OS:Pop!_OS 22.04 LTS

travier commented 2 years ago

Hum, is this a Flatpak specific issue? Might be better to report directly on bugs.kde.org.

root-reborn commented 2 years ago

Hum, is this a Flatpak specific issue? Might be better to report directly on bugs.kde.org.

I think this is a flatpak specific issue because I just now tested all these issues I reported here (Issues #205 , #210, #211) by installing okular in a virtualbox virtual machine(VM) running pop os using "sudo apt install okular"(okular version:21.12.3 is installed).Let us say the okular installed this way as "non-flatpak-okular".After repeating the "steps to reproduce" of issue #211 I observed that the "non-flatpak-okular" is not at all embedding the font inside the pdf file after doing Inline note,instead it is storing the font in some location of the OS which looks something like "/usr/share/fonts/opentype/urw-base35/font_name.otf" and pointing this path to fetch the font when pdf file is opened(although this will lead to portability issues for annotated pdf files in future). Thats why a 761.4KB pdf file of "Okular Handbook" is increased to only 762.2KB after doing Inline Note in it via non-flatpak-okular(beacuse non-flatpak-okular don't embed the fonts in pdf file) but is increased to 1.5MB when did the same Inline Note but via okular flatpak version(because okular flatpak fully embeds the font inside the pdf file itself).

Since there is no question of font embedding in non-flatpak-okular so this issue is a Flatpak specific issue.

root-reborn commented 2 years ago

Hum, is this a Flatpak specific issue? Might be better to report directly on bugs.kde.org.

Also I am not sure about issue #210 but I admit that the issue #205 is also observed in "non-flatpak-okular" but instead of properties menu showing default font as the font value for any Inline Note(i.e "fira sans book" for flatpak okular and "noto sans regular" for non-flatpak-okular are default fonts) the properties menu is showing some other random font when issue #205 is reproduced in non-flatpak-okular.

So atleast issue #205 is not a Flatpak specific issue.So I will try to report it at bugs.kde.org if possible.Since I don't use non-flatpak-okular so I can't keep up with its bug updates,so if possible you can also report this issue there.

travier commented 2 years ago

OK, so it looks like we need to include some more fonts by default in the Okular Flatpak. At least those used by default for annotations.

root-reborn commented 2 years ago

I am not sure about what you said because the default font of Okular Flatpak is " Fira Sans Book 10pt" and annotations with it are working fine in Okular Flatpak.So the default font is already included in Okular Flatpak.The only problem is with using other fonts instead of the default font in Okular Flatpak for annotations.I am not sure how to fix this issue and even workarounds also don't seem to be working as addressed in issue #211.