flathub / org.lamport.tla.toolbox

https://flathub.org/apps/details/org.lamport.tla.toolbox
2 stars 2 forks source link

Bump runtime to 22.08 #28

Closed bbhtt closed 1 year ago

bbhtt commented 2 years ago

I took the release date from the tag creation date https://github.com/tlaplus/tlaplus/releases/tag/v1.8.0 I think it has the wrong release date on Github for 1.8.0 as it says 07 Dec 2020 but 1.7.2 was on 03 Feb 2022

Ping @jesmg, please review, when you find time, thanks!

bbhtt commented 2 years ago

bot, build

flathubbot commented 2 years ago

Queued test build for org.lamport.tla.toolbox.

flathubbot commented 2 years ago

Started test build 102034

flathubbot commented 2 years ago

Build 102034 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/99745/org.lamport.tla.toolbox.flatpakref
jesmg commented 2 years ago

Thank you! But since 1.8.0 is in pre-release status (there still are some bugs to fix), I think is better to maintain the Flatpak in the latest stable release.

I will update to 1.8.0 when the definitive version is released.

bbhtt commented 2 years ago

Thank you! But since 1.8.0 is in pre-release status (there still are some bugs to fix), I think is better to maintain the Flatpak in the latest stable release.

I will update to 1.8.0 when the definitive version is released.

I can drop that change then but you still want the runtime bump since 19.08 is long EOL.

jesmg commented 2 years ago

Ok! :)

flathubbot commented 2 years ago

Started test build 105165

flathubbot commented 2 years ago

Build 105165 failed

flathubbot commented 2 years ago

Started test build 105180

flathubbot commented 2 years ago

Build 105180 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/102864/org.lamport.tla.toolbox.flatpakref
bbhtt commented 2 years ago

x-data-checker check is failing:

INFO    src.manifest: Checking 1 external data items
INFO    src.manifest: Started check [1/1] archive tlatoolbox/TLAToolbox-1.7.1-linux.gtk.x86_64.zip (from org.lamport.tla.toolbox.yml)
ERROR   src.manifest: Failed to check archive tlatoolbox/TLAToolbox-1.7.1-linux.gtk.x86_64.zip with HTMLChecker: Error downloading upstream source: 404, message='Not Found', url=URL('https://github.com/tlaplus/tlaplus/releases/download/v1.7.2/TLAToolbox-1.7.2-linux.gtk.x86_64.zip')
WARNING src.main: Check finished with 1 error(s)

1.7.2 never had such a release archive https://github.com/tlaplus/tlaplus/releases/tag/v1.7.2 Is 1.7.2 also a pre-release of some sort?

hfiguiere commented 2 years ago

1.7.2 called for replacing the .jar file as I understand it.

jesmg commented 2 years ago

It seems that 1.7.2 replaced the binaries of the 1.7.1 release, instead of having their own binaries. So x-data-checker is going to fail.

We will need to fix the checksum of the release file since it has changed

bbhtt commented 2 years ago

Is there anything I need to do here? Maybe merge this as is and track the failing x-checker later; it shouldn't be a blocker.

We will need to fix the checksum of the release file since it has changed

What checksum? The x-checker is looking for the zip TLAToolbox-$version-linux.gtk.x86_64.zip which 1.7.2 doesn't have, I think.

hfiguiere commented 2 years ago

she we merge this anyway?

flathubbot commented 1 year ago

Started test build 32066

flathubbot commented 1 year ago

Build 32066 failed

flathubbot commented 1 year ago

Started test build 32068

bbhtt commented 1 year ago

I removed the x-checker since releases from 1.7.x continues not to have the zip file (the latest one 1.7.3 only has a jar)

flathubbot commented 1 year ago

Build 32068 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/14714/org.lamport.tla.toolbox.flatpakref
bbhtt commented 1 year ago

cc @jesmg Any news?

hfiguiere commented 1 year ago

I'll merge this, since this is an EOL runtime. (has been for 2 years)

bbhtt commented 1 year ago

Thanks!