flathub / org.laptop.TurtleArtActivity

https://flathub.org/apps/details/org.laptop.TurtleArtActivity
1 stars 5 forks source link

Update runtime to GNOME 42 #7

Closed starnight closed 2 years ago

starnight commented 2 years ago
flathubbot commented 2 years ago

Started test build 111615

flathubbot commented 2 years ago

Build 111615 failed

wjt commented 2 years ago

5 contained this commit https://github.com/flathub/org.laptop.TurtleArtActivity/pull/5/commits/590b05c438dc9bed97cb94ddb17fdf6679f2680c which added numpy to fix an error observed in this comment https://github.com/flathub/org.laptop.TurtleArtActivity/pull/5#issuecomment-843954442

flathubbot commented 2 years ago

Started test build 111619

flathubbot commented 2 years ago

Build 111619 failed

flathubbot commented 2 years ago

Started test build 111621

flathubbot commented 2 years ago

Build 111621 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/109230/org.laptop.TurtleArtActivity.flatpakref
wjt commented 2 years ago

If you open the Plugins menu, enable all plugins, and restart, you'll see:

Failed to load Audio_sensors: No module named 'numpy'

So we do need 'numpy'

wjt commented 2 years ago

The upstream regression mentioned at https://github.com/flathub/org.laptop.TurtleArtActivity/pull/5#issuecomment-843954442 is still present:

Traceback (most recent call last):
  File "/app/lib/python3.9/site-packages/TurtleArt/tawindow.py", line 1241, in _buttonpress_cb
    self.button_press(
  File "/app/lib/python3.9/site-packages/TurtleArt/tawindow.py", line 1311, in button_press
    elif self._check_for_anything_else(spr, x, y):
  File "/app/lib/python3.9/site-packages/TurtleArt/tawindow.py", line 1624, in _check_for_anything_else
    self._select_category(spr)
  File "/app/lib/python3.9/site-packages/TurtleArt/tawindow.py", line 1794, in _select_category
    self.show_palette(i)
  File "/app/lib/python3.9/site-packages/TurtleArt/tawindow.py", line 987, in show_palette
    self.show_toolbar_palette(n)
  File "/app/lib/python3.9/site-packages/TurtleArt/tawindow.py", line 1097, in show_toolbar_palette
    self.palette_views[n].create(regenerate=regenerate, show=show)
  File "/app/lib/python3.9/site-packages/TurtleArt/tapaletteview.py", line 64, in create
    self._create_proto_blocks()
  File "/app/lib/python3.9/site-packages/TurtleArt/tapaletteview.py", line 198, in _create_proto_blocks
    self._proto_skin(name + 'small', self.blocks[-1].spr)
  File "/app/lib/python3.9/site-packages/TurtleArt/tapaletteview.py", line 211, in _proto_skin
    x, y = self._turtle_window.calc_image_offset(name, spr)
  File "/app/lib/python3.9/site-packages/TurtleArt/tawindow.py", line 4863, in calc_image_offset
    iw = self.media_shapes[name].get_width()
KeyError: 'camera1small'

but to me this is not reason enough to not update the app.

flathubbot commented 2 years ago

Started test build 111774

starnight commented 2 years ago

If you open the Plugins menu, enable all plugins, and restart, you'll see:

Failed to load Audio_sensors: No module named 'numpy'

So we do need 'numpy'

Sure! Updated to the fixed commit.

flathubbot commented 2 years ago

Build 111774 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/109380/org.laptop.TurtleArtActivity.flatpakref
flathubbot commented 2 years ago

Started test build 111799

flathubbot commented 2 years ago

Build 111799 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/109406/org.laptop.TurtleArtActivity.flatpakref
wjt commented 2 years ago

@tchx84 do you have the power? Any further feedback here?

tchx84 commented 2 years ago

@wjt done!