flathub / org.libreoffice.LibreOffice

https://flathub.org/apps/details/org.libreoffice.LibreOffice
29 stars 18 forks source link

No longer append appdata for components to flatpak's metainfo #237

Closed stbergmann closed 1 year ago

stbergmann commented 1 year ago

This had originally been added with https://github.com/flathub/org.libreoffice.LibreOffice/commit/945f6caad87658b1df1e8918bd5f64939058ab7f "clean up desktop integration", see its part "append the appdata for the separate apps (Base, Draw, etc) to the appdata XML we export for Flatpak, so they are visible in software centers etc". But it now started to cause Flathub builds (like https://buildbot.flathub.org/#/builders/14/builds/3985) to fail its "Check for right id in AppStream xml" step, and reportedly "the problem is there are multiple components in the metainfo file and I'm not sure it's allowed" (https://matrix.to/#/!RfXaBjokqHAbzZrgHz:matrix.org/$jWhob-a4LEH-e_TXsJwGWNfMYLF1kcWpXV_oW982ZpI?via=matrix.org&via=gnome.org&via=kde.org).

The solution appears to be to just remove that again (https://matrix.to/#/!RfXaBjokqHAbzZrgHz:matrix.org/$Yrzf_ZjJxBgUVs6kuP_10Tneu1t1wKQJCM_SC1vNHC4?via=matrix.org&via=gnome.org&via=kde.org):

I think maybe the problem was from the times that GNOME Software was also moonlighting as a menu editor that without Flatpak providing the metainfo for LibreOffice's different desktop launchers, they were invisible in GNOME Software, which meant you couldn't add/remove them to menus or the desktop but since then GNOME just shows all of the launchers, and menu editing / categories mostly died or sank to the bottom of the 1990s ocean so maybe this is a non-problem [...] ah ok ah so they don't show any more 🤣

flathubbot commented 1 year ago

Started test build 45924

flathubbot commented 1 year ago

Started test build 45962

flathubbot commented 1 year ago

Build 45924 failed

flathubbot commented 1 year ago

Build 45962 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/28582/org.libreoffice.LibreOffice.flatpakref