flathub / org.mixxx.Mixxx

https://flathub.org/apps/details/org.mixxx.Mixxx
7 stars 6 forks source link

Update to Mixxx version 2.4 with updated dependencies #52

Closed djantti closed 4 months ago

djantti commented 5 months ago

Mixxx 2.4 is nearing release, so I'm already submitting this PR in hopes that it will be tested, reviewed and ready to go as close to final release day as possible. At the moment it's using the 2.4 git branch, but I'll update the manifest once the 2.4 tarball is available.

Changes include:

I've tested my local build of this flatpak fairly extensively and used it on gigs without issues. Version 2.4 is a big update for Mixxx, so let me know if anything should be changed or improved. Happy DJing!

flathubbot commented 5 months ago

Started test build 93494

flathubbot commented 5 months ago

Build 93494 failed

flathubbot commented 5 months ago

Started test build 93497

flathubbot commented 5 months ago

Build 93497 failed

hfiguiere commented 5 months ago

Build fail because appstream file doesn't validate

        "style-invalid         : <li> is too long [Migration to Qt6 (work in progress) #4052 #4295 #4293 #4294 #4291 #4290 #4300 #4302 #4289 #4292 #4299 #4051 #4303 #4305 #4304 #4306 #4308 #4309 #4322 #4373 #4371 #4375 #4378 #4381 #4380 #4376 #4379 #4372 #4377 #4387 #4391 #4392 #4395 #4397 #4396 #4402 #4405 #4394 #4404 #4401 #4400 #4403 #4407 #4399 #4406 #4420 #4415 #4417 #4419 #4416 #4418 #4547 #4433 #4434 #4441 #4445 #4446 #4444 #4436 #4437 #4440 #4430 #4435 #4443 #4439 #4442 #4438 #4449 #4451 #4453 #4478 #4479 #4506 #4556 #4554 #4555 #4552 #4549 #4788 #4620 #4641 #4649 #4679 #10928 #10927 #11063 #11153 #11180 #11167 #11181 #11266 #11312 #11389 #4393 #12268 #12240 #12056 #12430 #12029] maximum is 500 chars",
        "style-invalid         : <li> is too long [Misc. refactorings #3154 #2870 #2872 #2978 #2969 #3016 #3320 #3356 #3453 #3487 #3558 #3685 #3741 #3744 #3753 #3761 #3834 #3842 #3853 #3874 #3883 #3922 #3947 #3974 #4024 #4026 #4034 #4038 #4039 #4043 #4053 #4072 #4097 #4096 #4118 #4130 #4129 #4109 #4106 #4131 #4140 #3032 #4110 #4173 #4178 #4194 #4197 #4190 #4212 #4223 #4238 #4236 #4320 #4325 #4203 #3861 #3514 #3274 #3182 #4343 #4358 #4388 #4427 #4341 #4473 #4464 #4481 #4527 #4534 #4537 #4539 #4541 #4543 #4546 #4542 #4559 #4574 #4581 #4582 #4598 #4596 #4592 #4784 #4604 #4603 #4611 #4605 #4583 #4636 #4644 #4653 #4655 #4609 #4647 #4660 #4663 #4661 #4670 #4672 #4674 #4618 #4690 #4724 #4730 #4731 #4732 #4728 #4737 #4739 #4745 #4765 #4767 #4797 #4782 #4800 #4791 #4848 #4856 #4860 #4867 #4888 #4908 #4903 #8818 #4907 #10897 #10964 #10963 #11048 #11149 #11169 #11318 #11331 #11338 #4651 #11336 #11282 #11421 #11431 #11434 #11301 #11688 #11685 #12000 #12003 #11684 #12031 #12008 #12054 #11768 #11893 #11636 #12026 #12230 #12375 #11619 #11917 #11936 #12033 #12263 #12212 #12066 #12065] maximum is 500 chars",
        "style-invalid         : <li> is too long [Note: Mixxx does not yet support multiple loops per track. We are working on this for Mixxx 2.4 . In Mixxx 2.3, if you import a track with multiple loops from Serato, Mixxx will use the first loop cue as the single loop Mixxx currently supports. The imported loops are still stored in Mixxx's database and are treated as hotcues in Mixxx 2.3. If you do not delete these hotcues, they will be usable as loops in Mixxx 2.4. Serato keeps loops and hotcues in separate lists, but Mixxx does not, so loops from Serato are imported starting as hotcue 9.] maximum is 500 chars",
        "tag-missing           : <content_rating> required [use https://odrs.gnome.org/oars]"
flathubbot commented 5 months ago

Started test build 93542

flathubbot commented 5 months ago

Build 93542 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/76287/org.mixxx.Mixxx.flatpakref
djantti commented 5 months ago

Looks like the bot is happy! I did a quick run and things appear to be working. Only problem is that LV2 plugins are no longer listed, so I'll add back the LV2_PATH environment variable. After that I'll ask folks to test the build as much as they can.

hfiguiere commented 5 months ago

the problem is the wrapper script is missing the export statement. (see at bottom of the manifest)

hfiguiere commented 5 months ago

we probably did never notice because there was the --env.

djantti commented 5 months ago

Ah yes, good catch! That is a better fix.

flathubbot commented 5 months ago

Started test build 93567

flathubbot commented 5 months ago

Build 93567 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/76312/org.mixxx.Mixxx.flatpakref
flathubbot commented 4 months ago

Started test build 99218

flathubbot commented 4 months ago

Build 99218 failed

flathubbot commented 4 months ago

Started test build 99589

flathubbot commented 4 months ago

Build 99589 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82380/org.mixxx.Mixxx.flatpakref
Be-ing commented 4 months ago

I updated libmad in the shared-modules repository (https://github.com/flathub/shared-modules/pull/292). Please update the git submodule in this PR.

flathubbot commented 4 months ago

Started test build 99859

flathubbot commented 4 months ago

Build 99859 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82654/org.mixxx.Mixxx.flatpakref
flathubbot commented 4 months ago

Started test build 100527

flathubbot commented 4 months ago

Build 100527 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/83310/org.mixxx.Mixxx.flatpakref
djantti commented 4 months ago

This PR has now been updated to Mixxx 2.4.0 final release and hopefully things are in good enough shape to be merged. Let me know if there are additional changes needed.

Be-ing commented 4 months ago

Ping @FakeShemp this is ready to merge to update to the new upstream 2.4.0 release.