search

flathub / org.mozilla.Thunderbird

https://flathub.org/apps/details/org.mozilla.Thunderbird
43 stars 18 forks source link

Thunderbird 78.3.1 #120

Closed ovari closed 4 years ago

ovari commented 4 years ago

Thunderbird Release Notes Version 78.0, first offered to channel users on July 17, 2020 https://www.thunderbird.net/thunderbird/78.0/releasenotes/

Erick555 commented 4 years ago

Fixed with https://github.com/flathub/org.mozilla.Thunderbird/pull/140

ovari commented 4 years ago

@Erick555 should the beta branch be deleted?

ovari commented 4 years ago

Should the image at Flathub be updated?

Perhaps with an image from the official Thunderbird page, eg. image

What do you think?

Thank you

Erick555 commented 4 years ago

beta branch is protected and can't be deleted (also shouldn't be for transparency reasons as it reveals what's behind TB releases published in beta which will be still publicly available). I'll take a look at screenshots.

Erick555 commented 4 years ago

Unfortunately official screenshots aren't suited for flatpak:

$ appstream-util validate org.mozilla.Thunderbird.appdata.xml
org.mozilla.Thunderbird.appdata.xml: FAILED:
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/thundernest/thunderbird-website/1b96bb5c609cfa9d838807903fada3470e43fa7b/media/img/l10n/en-US/thunderbird/landing/screenshot-linux.png]
Validation of files failed
ovari commented 4 years ago

Below is the image with the padding removed at the left, top and right. image

Below is the image with the shading also removed from the bottom. image

Does this work?

Thank you

Erick555 commented 4 years ago

Still fail:

appstream-util validate org.mozilla.Thunderbird.appdata.xml
org.mozilla.Thunderbird.appdata.xml: FAILED:
• attribute-invalid     : <screenshot> height too small [https://user-images.githubusercontent.com/17465872/94857227-85a78d80-0474-11eb-9591-c381dcd495c9.png] minimum is 351px

We can't really use those. You may create your own screenshot that follows https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html:

Ideally, all image screenshots as well as videos should have a 16:9 aspect ratio, and should have a width that is no smaller than 620 pixels.

then add it to forked git repo and change link at https://github.com/flathub/org.mozilla.Thunderbird/blob/master/org.mozilla.Thunderbird.appdata.xml#L64 so it would point to new image and open PR.