flathub / org.mozilla.Thunderbird

https://flathub.org/apps/details/org.mozilla.Thunderbird
43 stars 18 forks source link

Incorrect path for local folders is displayed #227

Closed pgalbraith closed 2 years ago

pgalbraith commented 2 years ago

In account settings, I cannot change the folder location of "Local Folders".

Erick555 commented 2 years ago

Did you try to type or paste new folder location address?

Erick555 commented 2 years ago

Anyway it works for me - under Local directory I clicked on browse then selected new folder. App proposed restart and after that new folder was active.

pgalbraith commented 2 years ago

I can't manually edit the field, I have to click browse and choose a folder. When I do (and restart) it doesn't actually change, though, it's still locked into a flatpak directory. I had to uninstall the flatpak version and install from deb package instead (I'm running Pop!_OS 21.10) and only then could I specify the local folders location.

Erick555 commented 2 years ago

Is there anything special about the new location you want to use? Is it under /home/<user>/.var/app/org.mozilla.Thunderbird? /home/<user>? Different filesystem?

pgalbraith commented 2 years ago

I keep it under a DropBox folder in my home directory, but I don't think there's anything special about that. Thunderbird from the deb packages certainly has no problem with it.

pgalbraith commented 2 years ago

Ahhhh maybe this is just me not understanding flatpak...does /run/flatpak/doc/xxxxxxxx/ typically map to my user home directory?

Erick555 commented 2 years ago

It maps it through file portal which uses fuse filesystem but I think thunderbird may not like this format for its internal configuration. You my try allowing this path directly in sandbox with: flatpak override --user --filesystem=~/<path/to/folder/ org.mozilla.Thunderbird ie: flatpak override --user --filesystem=~/Dropbox/Localmail org.mozilla.Thunderbird. Then start app and try changing local mail folder again.

pgalbraith commented 2 years ago

Ok so I've figured out that it is actually working, I was just thrown off by the fuse filesystem. This is what I see in the settings:

image

But that is actually mapping to /home/paul/Dropbox/Thunderbird/Local Folders. If I did the override that you've suggested, what would change?

Erick555 commented 2 years ago

If you do override (and adjust path in settings) then thunderbird will see this path directly as /home/paul/Dropbox/Thunderbird/Local Folders without fuse intermediary. If it works as is then it's not necessary.

pgalbraith commented 2 years ago

Ok well I'm happy, though really I think the correct folder should be displayed right out of the gate. Not sure if that's worth tracking as an issue here or not, though.

Erick555 commented 2 years ago

Without override thunderbird can access this path only through fuse portal so the path you see is the only one that exist from app perspective. There is no /home/paul/Dropbox/Thunderbird/Local Folders path available to app.

pgalbraith commented 2 years ago

Ok so it sounds like doing that manual override is a good workaround to the issue, but it's still an issue nonetheless.

Erick555 commented 2 years ago

The issue is not-actionable though. Accessing files through portals is fundamental for flatpak apps.

pgalbraith commented 2 years ago

@Erick555 just because it's not an easy fix, doesn't mean it's not an issue.

Erick555 commented 2 years ago

I didn't say it's not an easy fix but it's not actionable -> not fixable.

pgalbraith commented 2 years ago

@Erick555 I don't believe this is the way that the Thunderbird devs intend it to work. Things like this are always actionable, but may be a heavy lift. I think it's a disservice to both the devs and users to pretend that there's no problem here. Unfortunately, it is a very deeply embedded problem with no easy fix. Things like this are usually worth keeping track of.

Erick555 commented 2 years ago

From flatpak perspective everything is working as intended. Files are accessed through portals. Portals paths reside under /run/flatpak/doc/. For thunderbird it shouldn't make difference where the path is mounted as long as it resolves to one chosen by user and you confirmed it does. I understand users may be confused about the strange path but it's purely cosmetic issue tied to flatpak inner design which make it not fixable by any party and it's shared for all flatpak apps.

I don't see point of keeping this issue open. I can't fix it. Thunderbird devs can't. Core functionality works. What do you expect to happen then?

pgalbraith commented 2 years ago

This is an issue with the flatpak packaging of Thunderbird. It is not working as intended.

Erick555 commented 2 years ago

Then please describe what doesn't work and what you propose to fix this.

pgalbraith commented 2 years ago

@Erick555 the issue is that Thunderbird is not displaying the intended information in the dialog box. I do not have a solution to this problem, I am merely pointing out the issue.

pgalbraith commented 2 years ago

The whole point of my being stubborn about this is that, just because there's no obvious or easy solution, does not in any way change the fact that there is an issue.

Erick555 commented 2 years ago

Thunderbird is accessing /run/flatpak/doc/and the same path is shown in your screenshot. Thunderbird can't access /home/paul/Dropbox/Thunderbird because it's not available for the app and obviously it can't show unavailable path in dialog or even know about.

All flatpak apps are containerized and filesystem inside container is totally different than filesystem on your host. This is by design not a bug somewhere. For thunderbird there is no issue and for flatpak there is no issue either which is why there won't be easy or hard solution for it. There won't be any solution at all.

There is nothing else to add here from me. I hope this clears all points.

pgalbraith commented 2 years ago

No it really doesn't. For the user, there is an issue in the interface and you're glossing over it because you don't know how to do anything about it. The dialog in the screen shot above is not showing the correct path/folder. Yes, I understand why. Understanding why does not make it correct.

Erick555 commented 2 years ago

Please elevate this to flatpak. They may tell you the same thing as I do but you can try. I'm sorry but I really can't help you here. I wish I could.

pgalbraith commented 2 years ago

That's my whole point, this is a real issue, not easily solved, and it really points to an underlying problem in flatpak that really impact a lot of applications. An issue should be opened there, and this issue linked to it as parent. I'd expect you to do that as you know a lot more about flatpak than I do. Tracking the issues is the first step in getting attention to large problems like this. Don't sweep it under the rug.

Erick555 commented 2 years ago

All I know about flatpak tells it's unchangeable. You can disagree but expecting I would spend time representing your opinion which I don't share is a bit too much.

pgalbraith commented 2 years ago

Interesting, so you believe that when a user in this situation selects a folder under their home directory, it in fact should display in the UI as /run/flatpak/.... In that case, yes, we definitely don't share the same opinion.

Erick555 commented 2 years ago

Yes, this is exactly what I'm telling you. Displaying /run/flatpak/ is correct behavior.