search

flathub / org.openscad.OpenSCAD

https://flathub.org/apps/details/org.openscad.OpenSCAD
0 stars 7 forks source link

Update OpenSCAD to 2019.05 #5

Closed goncalossilva closed 4 years ago

goncalossilva commented 5 years ago

This PR updates OpenSCAD to 2019.05. I've tested and updated the build config so that it builds successfully for the newer version, but have not tested the app itself (ie. ran all steps up to number 4, inclusive). I am inexperienced with flatpak and unsure how to handle step 5 for OpenSCAD specifically. Building works, and hopefully this PR makes it easier to update to the new version.

Closes #4.

flathubbot commented 5 years ago

Started test build 5741

flathubbot commented 5 years ago

Build 5741 failed

goncalossilva commented 5 years ago

I have disabled unsupported architectures in the last commit. I am unsure how to handle the remaining problem. In sum, OpenSCAD's icon is 688x688 and it is expected to be 512x512 when moved.

It could make sense to have imagemagick as a build time dependency to resize this, but I am unsure about the best way to do that. The "modules" key lists out run time dependencies. Is there a similar entry for build time dependencies?

flathubbot commented 5 years ago

Started test build 5753

flathubbot commented 5 years ago

Build 5753 failed

flathubbot commented 5 years ago

Started test build 5775

flathubbot commented 5 years ago

Build 5775 failed

goncalossilva commented 5 years ago

Icon is handled, but now appstream verification fails and I am way out of my comfort zone. I hope the remaining work is helpful. :+1:

tpimh commented 5 years ago

I have built and tested it locally, everything works as expected. No idea why did it fail the checks.

goncalossilva commented 4 years ago

Closing in favor of #6